From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Yt9Kb-0005M5-J0
	for qemu-devel@nongnu.org; Fri, 15 May 2015 02:42:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Yt9KW-0003rn-Bx
	for qemu-devel@nongnu.org; Fri, 15 May 2015 02:42:49 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:15610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1Yt9KV-0003rR-S6
	for qemu-devel@nongnu.org; Fri, 15 May 2015 02:42:43 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout4.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NOD0051QPB56890@mailout4.w1.samsung.com> for
	qemu-devel@nongnu.org; Fri, 15 May 2015 07:42:41 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <1431624430-3996-1-git-send-email-ashoks@broadcom.com>
In-reply-to: <1431624430-3996-1-git-send-email-ashoks@broadcom.com>
Date: Fri, 15 May 2015 09:42:40 +0300
Message-id: <00c401d08eda$57394490$05abcdb0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary
	GICv3	support for kvm mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Ashok Kumar' <ashoks@broadcom.com>, qemu-devel@nongnu.org
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

 Hello!

> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
> them.
> 
> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>

 I also work on this, just not published yet. Some notes about your version:
1. May be there should be hw/intc/arm_gicv3_kvm.c file created for GICv3? As far as i can
see, save/restore code should differ a lot.
2. kvm_arch_irqchip_create() should probe only for type we want to get. It has to be
passed there somehow from the virt machine initializer. And, if we want GICv3, then upon
failure it should return error, not zero. This is because when kvm_arch_irqchip_create()
returns zero, a fallback code is used, which will create GICv2.
3. Perhaps you should base your work on these patch sets:
    https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00941.html
    https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01505.html

 I added Shlomo to cc because he might also be interested.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia