Re: [PATCH] drm/amdgpu: fix the warning about the expression (int)size - len

["Christian König" <christian.koenig@amd.com>]

Am 25.04.24 um 08:20 schrieb Jesse Zhang:
> Converting size from size_t to int may overflow.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index f5d0fa207a88..b828aad4f35e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
>   	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
>   	char reg_offset[11];
>   	uint32_t *new = NULL, *tmp = NULL;
> -	int ret, i = 0, len = 0;
> +	int ret, i = 0;
> +	unsigned int len = 0;

Please keep reverse xmas tree order here, apart from that looks good to me.

Regards,
Christian.

>   
>   	do {
>   		memset(reg_offset, 0, 11);
>   		if (copy_from_user(reg_offset, buf + len,
> -					min(10, ((int)size-len)))) {
> +					min(10, (size-len)))) {
>   			ret = -EFAULT;
>   			goto error_free;
>   		}