All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hank Yang" <hanky@promise.com.tw>
To: "Martin Dalecki" <dalecki@evision-ventures.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
	"Linus Chen" <linusc@promise.com.tw>
Subject: Re: [PATCH] Submitting PROMISE IDE Controllers Driver Patch
Date: Fri, 8 Mar 2002 10:00:04 +0800	[thread overview]
Message-ID: <00cd01c1c644$f6da4520$59cca8c0@hank> (raw)
In-Reply-To: <014701c1c5b6$a0dfb620$59cca8c0@hank> <3C876199.5000107@evision-ventures.com>

> 1. Are there any praticular reasons for the fact that you
>     define the PCI_VENDOR_ID_PROMISE in ide-disk.c instead of
>     the kernel global ID header.

I find out it's already defined in pci_ids.h so shouldnt be needed here.
We will update this point later.
 
> 2. Why are you gurading all lba48 accesses by the promise
>     vendor id?

That's because we don't want to influence the on-board IDE and other IDE
controller's R/W routine. So it will just works on PROMISE controllers.
 
> 3. Are there any reasons for enabling the IDEDMA_TIMEOUT handling
>     unconditionally?

If we enable IDEDMA_TIMEOUT, kernel will look for
ide_dma_timeout_revovery() to retry again when drive's DMA timeout.

Thank you for yours efforts to look at this patch.

Best Regards
Hank Yang



  parent reply	other threads:[~2002-03-08  2:01 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-07  9:01 [PATCH] Submitting PROMISE IDE Controllers Driver Patch Hank Yang
2002-03-07 10:23 ` Arjan van de Ven
2002-03-08  1:45   ` Hank Yang
2002-03-08  2:10     ` Alan Cox
2002-03-08  3:01       ` Hank Yang
2002-03-08  8:19         ` Martin Dalecki
2002-03-08  8:23           ` arjan
2002-03-08  8:35             ` Martin Dalecki
2002-03-08  8:50               ` Arjan van de Ven
2002-03-08  9:14                 ` Martin Dalecki
2002-03-08 13:12                 ` Alan Cox
2002-03-08 19:25                 ` Kelsey Hudson
2002-03-09 13:25                   ` Martin Dalecki
2002-03-08 13:25         ` Alan Cox
2002-03-13  7:35           ` Hank Yang
2002-03-13  7:45             ` Arjan van de Ven
2002-03-08  2:54     ` Kelsey Hudson
2002-03-08  7:54     ` Arjan van de Ven
2002-03-08  8:12     ` Martin Dalecki
2002-03-07 13:15 ` Alan Cox
2002-03-08  3:49   ` Hank Yang
2002-03-08 13:14     ` Alan Cox
2002-03-13  6:52       ` Hank Yang
2002-03-13 16:39         ` Alan Cox
2002-05-22  9:38           ` Hank Yang
     [not found]           ` <039701c20892$3940ca30$c0cca8c0@promise.com.tw>
2002-05-31 14:33             ` [PATCH] Submitting PROMISE IDE " Alan Cox
2002-06-03  3:51               ` [PATCH] 2.4.19pre9 in pdc202xx.c bug Hank Yang
2002-06-03 15:48                 ` Alan Cox
2002-06-06  2:31                   ` Hank Yang
2002-06-06 12:17                     ` Alan Cox
     [not found] ` <3C876199.5000107@evision-ventures.com>
2002-03-08  2:00   ` Hank Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-03-10 14:23 [PATCH] Submitting PROMISE IDE Controllers Driver Patch Ed Tomlinson
2002-03-10 14:47 ` Alan Cox
2002-03-11  9:56   ` benh
     [not found] <200203071331.g27DVi211087@sunrise.pg.gda.pl>
2002-03-07 13:36 ` Andrzej Krzysztofowicz
2002-03-07  6:46 Hank Yang
2002-03-09 21:23 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00cd01c1c644$f6da4520$59cca8c0@hank' \
    --to=hanky@promise.com.tw \
    --cc=dalecki@evision-ventures.com \
    --cc=linusc@promise.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.