From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lloyd Atkinson Subject: Re: [PATCH 3/3] drm/msm/dsi: check msm_dsi and dsi pointers before use Date: Mon, 15 Jan 2018 10:01:45 -0500 Message-ID: <00cdfe41-12fd-e57b-5166-b6236cf66d37@codeaurora.org> References: <1515790531-157273-1-git-send-email-latkinso@codeaurora.org> <1515790531-157273-4-git-send-email-latkinso@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: linux-arm-msm , dri-devel List-Id: linux-arm-msm@vger.kernel.org T24gMS8xNS8yMDE4IDk6NDggQU0sIFJvYiBDbGFyayB3cm90ZToKPiBPbiBGcmksIEphbiAxMiwg MjAxOCBhdCAzOjU1IFBNLCBMbG95ZCBBdGtpbnNvbiA8bGF0a2luc29AY29kZWF1cm9yYS5vcmc+ IHdyb3RlOgo+PiBNb3ZlIG51bGwgY2hlY2tzIG9mIHBvaW50ZXIgYXJndW1lbnRzIHRvIHRoZSBi ZWdpbm5pbmcgb2YgdGhlCj4+IG1vZGVzZXQgaW5pdCBmdW5jdGlvbiBzaW5jZSB0aGV5IGFyZSBy ZWZlcmVuY2VkIGltbWVkaWF0ZWx5Cj4+IGluc3RlYWQgb2YgYWZ0ZXIgdGhleSBoYXZlIGFscmVh ZHkgYmVlbiB1c2VkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBMbG95ZCBBdGtpbnNvbiA8bGF0a2lu c29AY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNp LmMgfCAyMiArKysrKysrKysrLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vbXNtL2RzaS9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaS5jCj4+IGlu ZGV4IDk4NzQyZDcuLmJlODU1ZGIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20v ZHNpL2RzaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaS5jCj4+IEBAIC0x OTYsNyArMTk2LDcgQEAgaW50IG1zbV9kc2lfbW9kZXNldF9pbml0KHN0cnVjdCBtc21fZHNpICpt c21fZHNpLCBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgICAgICAgIHN0cnVjdCBkcm1fYnJp ZGdlICpleHRfYnJpZGdlOwo+PiAgICAgICAgIGludCByZXQ7Cj4+Cj4+IC0gICAgICAgaWYgKFdB Uk5fT04oIWVuY29kZXIpKQo+PiArICAgICAgIGlmICghZW5jb2RlciB8fCAhbXNtX2RzaSB8fCAh ZGV2KQo+IAo+IGhtbSwgdGhlIGNoZWNraW5nIGlmIG1zbV9kc2kgaXMgbnVsbCBsYXRlciBpbiB0 aGUgZmFpbDogY2FzZSBpcwo+IGNlcnRhaW5seSBza2V0Y2h5IGFmdGVyIHdlJ3ZlIGFscmVhZHkg ZGVyZWYnZCBpdC4uICBzbyB0aGlzIGxvb2tzIGxpa2UKPiB0aGUgcmlnaHQgdGhpbmcuICBCdXQg SSdkIGxpa2UgdG8ga2VlcCB0aGUgV0FSTl9PTigpLCBzaW5jZSB0aGlzIGlzIGEKPiBjYXNlIHRo YXQgc2hvdWxkbid0IHJlYWxseSBoYXBwZW4uICBUaGUgV0FSTl9PTigpIG5pY2VseSBkb2N1bWVu dHMKPiB0aGF0IG5vbmUgb2YgdGhlc2UgcGFyYW1ldGVycyBhcmUgZXhwZWN0ZWQgdG8gYmUgTlVM TCwgYW5kIGl0IGdpdmVzIGEKPiBiaWcgc2hvdXR5IG1lc3NhZ2UgdG8gYW55b25lIHdobyBpbmFk dmVydGVudGx5IGNoYW5nZXMgc29tZXRoaW5nIHRoYXQKPiBicmVha3MgdGhhdCBhc3N1bXB0aW9u LiAgT3RoZXIgdGhhbiB0aGF0LCBpdCBsb29rcyBnb29kLgo+IAo+IEJSLAo+IC1SCgpTdXJlLiBE byB5b3Ugd2FudCB0byBhZGQgV0FSTl9PTnMgdG8gbXNtX2RzaSBhbmQgZGV2IGFzIHdlbGw/CgpU aGFua3MsCkxsb3lkCgo+IAo+IAo+PiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4+ Cj4+ICAgICAgICAgbXNtX2RzaS0+ZGV2ID0gZGV2Owo+PiBAQCAtMjQ1LDE5ICsyNDUsMTcgQEAg aW50IG1zbV9kc2lfbW9kZXNldF9pbml0KHN0cnVjdCBtc21fZHNpICptc21fZHNpLCBzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+Pgo+PiAgICAgICAgIHJldHVybiAwOwo+PiAgZmFpbDoKPj4gLSAg ICAgICBpZiAobXNtX2RzaSkgewo+PiAtICAgICAgICAgICAgICAgLyogYnJpZGdlL2Nvbm5lY3Rv ciBhcmUgbm9ybWFsbHkgZGVzdHJveWVkIGJ5IGRybTogKi8KPj4gLSAgICAgICAgICAgICAgIGlm IChtc21fZHNpLT5icmlkZ2UpIHsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgbXNtX2RzaV9t YW5hZ2VyX2JyaWRnZV9kZXN0cm95KG1zbV9kc2ktPmJyaWRnZSk7Cj4+IC0gICAgICAgICAgICAg ICAgICAgICAgIG1zbV9kc2ktPmJyaWRnZSA9IE5VTEw7Cj4+IC0gICAgICAgICAgICAgICB9Cj4+ ICsgICAgICAgLyogYnJpZGdlL2Nvbm5lY3RvciBhcmUgbm9ybWFsbHkgZGVzdHJveWVkIGJ5IGRy bTogKi8KPj4gKyAgICAgICBpZiAobXNtX2RzaS0+YnJpZGdlKSB7Cj4+ICsgICAgICAgICAgICAg ICBtc21fZHNpX21hbmFnZXJfYnJpZGdlX2Rlc3Ryb3kobXNtX2RzaS0+YnJpZGdlKTsKPj4gKyAg ICAgICAgICAgICAgIG1zbV9kc2ktPmJyaWRnZSA9IE5VTEw7Cj4+ICsgICAgICAgfQo+Pgo+PiAt ICAgICAgICAgICAgICAgLyogZG9uJ3QgZGVzdHJveSBjb25uZWN0b3IgaWYgd2UgZGlkbid0IG1h a2UgaXQgKi8KPj4gLSAgICAgICAgICAgICAgIGlmIChtc21fZHNpLT5jb25uZWN0b3IgJiYgIW1z bV9kc2ktPmV4dGVybmFsX2JyaWRnZSkKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgbXNtX2Rz aS0+Y29ubmVjdG9yLT5mdW5jcy0+ZGVzdHJveShtc21fZHNpLT5jb25uZWN0b3IpOwo+PiArICAg ICAgIC8qIGRvbid0IGRlc3Ryb3kgY29ubmVjdG9yIGlmIHdlIGRpZG4ndCBtYWtlIGl0ICovCj4+ ICsgICAgICAgaWYgKG1zbV9kc2ktPmNvbm5lY3RvciAmJiAhbXNtX2RzaS0+ZXh0ZXJuYWxfYnJp ZGdlKQo+PiArICAgICAgICAgICAgICAgbXNtX2RzaS0+Y29ubmVjdG9yLT5mdW5jcy0+ZGVzdHJv eShtc21fZHNpLT5jb25uZWN0b3IpOwo+Pgo+PiAtICAgICAgICAgICAgICAgbXNtX2RzaS0+Y29u bmVjdG9yID0gTlVMTDsKPj4gLSAgICAgICB9Cj4+ICsgICAgICAgbXNtX2RzaS0+Y29ubmVjdG9y ID0gTlVMTDsKPj4KPj4gICAgICAgICByZXR1cm4gcmV0Owo+PiAgfQo+PiAtLQo+PiBRVUFMQ09N TSBDYW5hZGEsIG9uIGJlaGFsZiBvZiBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBp cyBhIG1lbWJlcgo+PiBvZiBDb2RlIEF1cm9yYSBGb3J1bSwgaG9zdGVkIGJ5IFRoZSBMaW51eCBG b3VuZGF0aW9uCj4+Cj4+IC0tCj4+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5k IHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1hcm0tbXNtIiBpbgo+PiB0aGUgYm9keSBvZiBh IG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+PiBNb3JlIG1ham9yZG9tbyBp bmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKCgotLSAK UVVBTENPTU0gQ2FuYWRhLCBvbiBiZWhhbGYgb2YgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIs IEluYy4gaXMgYSBtZW1iZXIKb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGlu dXggRm91bmRhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK