From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported
Date: Fri, 16 Oct 2015 10:52:10 +0300 [thread overview]
Message-ID: <00ce01d107e7$90879720$b196c560$@samsung.com> (raw)
In-Reply-To: <CAFEAcA8u1ak3fKrxfcH1esEpujUW9QKOUxez_2Gb_1QKNQnSRg@mail.gmail.com>
Hello!
> But this is the GICv2 code. Unless there are kernels out in the wild
> which support v2 but not migration, there's no need to check
> for that situation here.
Such kernels do exist for sure, otherwise why do we have kvm_gic_can_save_restore() at all? I remember even you pointed me at it.
I've just checked LXR, we have vGIC support since 3.11, but KVM_DEV_TYPE_ARM_VGIC_V2 was introduced only in 3.14.
P.S. While studying migration code i discovered migrate_add_blocker(), i guess i need to use it instead of patching VMState, because checkpatch blames me for making it non-const. So, if you ACK the idea itself, i'll reimplement it and post v2.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-16 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:45 [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported Pavel Fedin
2015-10-15 16:38 ` Peter Maydell
2015-10-16 6:40 ` Pavel Fedin
2015-10-16 7:36 ` Peter Maydell
2015-10-16 7:52 ` Pavel Fedin [this message]
2015-10-16 13:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ce01d107e7$90879720$b196c560$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.