From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55798)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmzoI-0004kl-JI
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmzoE-000849-HG
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:18 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:12479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZmzoE-00083a-BL
	for qemu-devel@nongnu.org; Fri, 16 Oct 2015 03:52:14 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout2.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NWA00HKUZ6ZUD50@mailout2.w1.samsung.com> for
	qemu-devel@nongnu.org; Fri, 16 Oct 2015 08:52:11 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <010601d10747$569ae800$03d0b800$@samsung.com>
	<CAFEAcA-ndH_duvEL6vEBzVmU8uWqvJoVCzFEtHsvwFAYtnT2rg@mail.gmail.com>
	<00a501d107dd$7fd8b350$7f8a19f0$@samsung.com>
	<CAFEAcA8u1ak3fKrxfcH1esEpujUW9QKOUxez_2Gb_1QKNQnSRg@mail.gmail.com>
In-reply-to: <CAFEAcA8u1ak3fKrxfcH1esEpujUW9QKOUxez_2Gb_1QKNQnSRg@mail.gmail.com>
Date: Fri, 16 Oct 2015 10:52:10 +0300
Message-id: <00ce01d107e7$90879720$b196c560$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not
	supported
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>

 Hello!

> But this is the GICv2 code. Unless there are kernels out in the wild
> which support v2 but not migration, there's no need to check
> for that situation here.

 Such kernels do exist for sure, otherwise why do we have =
kvm_gic_can_save_restore() at all? I remember even you pointed me at it.
 I've just checked LXR, we have vGIC support since 3.11, but =
KVM_DEV_TYPE_ARM_VGIC_V2 was introduced only in 3.14.

 P.S. While studying migration code i discovered migrate_add_blocker(), =
i guess i need to use it instead of patching VMState, because checkpatch =
blames me for making it non-const. So, if you ACK the idea itself, i'll =
reimplement it and post v2.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia