All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Doug Nazar" <nazard@dragoninc.ca>
To: sparclinux@vger.kernel.org
Subject: RE: Unaligned accesses in ip_rcv and ip_fast_csum
Date: Tue, 27 Feb 2007 18:52:15 +0000	[thread overview]
Message-ID: <00d101c75aa0$66420b60$32c62220$@ca> (raw)
In-Reply-To: <20070225200702.GA4451@droopy.oc.cox.net>

> We have a report (Debian bug #409313 [0]) of the following unaligned
> accesses, occuring every 5-6 seconds on Netra X1 and SunFire v100 with
> kernel 2.6.18 and newer:

This took me a little longer to track down than it should have. I started
looking at the wrong end of the issue but on the plus side I now have a
better understanding sparcv9 asm and the networking stack.


diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 5a35354..e3774a5 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -67,7 +67,7 @@ const char * const medianame[32] = {
 
 /* Set the copy breakpoint for the copy-only-tiny-buffer Rx structure. */
 #if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \
-	|| defined(__sparc_) || defined(__ia64__) \
+	|| defined(__sparc__) || defined(__ia64__) \
 	|| defined(__sh__) || defined(__mips__)
 static int rx_copybreak = 1518;
 #else



  reply	other threads:[~2007-02-27 18:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25 20:07 Unaligned accesses in ip_rcv and ip_fast_csum Jurij Smakov
2007-02-27 18:52 ` Doug Nazar [this message]
2007-02-27 19:43 ` Doug Nazar
2007-02-27 20:00 ` David Miller
2007-02-27 20:22 ` Daniel J. Priem
2007-02-27 21:02 ` David Miller
2007-02-27 21:07 ` Daniel J. Priem
2007-02-27 21:14 ` David Miller
2007-02-27 22:19 ` Daniel J. Priem
2007-02-28 12:30 ` Richard Mortimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00d101c75aa0$66420b60$32c62220$@ca' \
    --to=nazard@dragoninc.ca \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.