From: Pavel Fedin <p.fedin@samsung.com>
To: 'Eric Auger' <eric.auger@linaro.org>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code
Date: Wed, 19 Aug 2015 09:36:19 +0300 [thread overview]
Message-ID: <00d201d0da49$5bb60e30$13222a90$@samsung.com> (raw)
In-Reply-To: <55D35512.1000903@linaro.org>
Hello!
> I think it would be worth justifying the changes in signature:
> removal of GICState* due to the introduction of GICV3State and also
> justify replacement of uint32_t *val into void*.
I described it in the cover letter. Right now you don't see usage for it, but here i started
prototyping live migration, and in some cases 'val' is going to be uint64_t. This is because
GICD_IROUTER registers are 64 bits wide. kvm_gic_access() by itself does not dereference the
pointer, just passes it to the kernel, therefore i decided to make it type-agnostic.
> what is the point of moving kvm_gicd_access and kvm_gicc_access here? If
> I am not mistaken, they only are used in arm_gic_kvm.c? I think they can
> stay static in arm_gic_kvm.c?
They will be used in future for live migration, at least kvm_gicd_access. kvm_gicc_access just
accompanies it to keep a single style for both.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-08-19 6:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 13:33 [Qemu-devel] [PATCH v10 0/5] vGICv3 support Pavel Fedin
2015-08-18 13:33 ` [Qemu-devel] [PATCH v10 1/5] hw/intc: Implement GIC-500 base class Pavel Fedin
2015-08-18 15:54 ` Eric Auger
2015-08-18 13:33 ` [Qemu-devel] [PATCH v10 2/5] intc/gic: Extract some reusable vGIC code Pavel Fedin
2015-08-18 15:53 ` Eric Auger
2015-08-19 6:36 ` Pavel Fedin [this message]
2015-08-19 7:13 ` Eric Auger
2015-08-18 13:33 ` [Qemu-devel] [PATCH v10 3/5] arm_kvm: Do not assume particular GIC type in kvm_arch_irqchip_create() Pavel Fedin
2015-08-18 15:57 ` Eric Auger
2015-08-18 13:33 ` [Qemu-devel] [PATCH v10 4/5] hw/intc: Initial implementation of vGICv3 Pavel Fedin
2015-08-18 16:11 ` Eric Auger
2015-08-19 6:44 ` Pavel Fedin
2015-08-18 13:33 ` [Qemu-devel] [PATCH v10 5/5] hw/arm/virt: Add gic-version option to virt machine Pavel Fedin
2015-08-19 14:08 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00d201d0da49$5bb60e30$13222a90$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.