From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David Denny" Subject: [BUG] Bugs during building 4.3.1 Date: Sun, 03 Nov 2013 13:02:19 -0500 Message-ID: <00d401ced8be$d7289530$8579bf90$@net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_00D5_01CED894.EE528D30" Return-path: Content-language: en-us List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. ------=_NextPart_000_00D5_01CED894.EE528D30 Content-Type: multipart/alternative; boundary="----=_NextPart_001_00D6_01CED894.EE52B440" ------=_NextPart_001_00D6_01CED894.EE52B440 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Hi! Thanks for the great software! I use it constantly. Thought I'd let you know of a few issues I ran into. #3 might be pretty easy to fix. 1. No spaces allowed in the base directory path! I guess some quotes are missing on variables in the makefiles. At least this is a "known limitation." 2. Configuration process does not check for openssl and x11, which I believe are both required. 3. APPEND_LIB doesn't carry through to all the makefiles. My openssl and x11 libraries are in non-standard locations (not in /usr/X11 or /usr/openssl). I've provided three very trivial patches that I hope will be more illustrative than my typing, but they are probably not production grade. I applied them prior to configuration and got a clean build. Best regards, David ------=_NextPart_001_00D6_01CED894.EE52B440 Content-Type: text/html; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable

Hi!

Thanks for = the great software! I use it constantly. Thought I’d = let you know of a few issues I ran into. #3 might be pretty easy = to fix.

1. No = spaces allowed in the base directory path! I guess some = quotes are missing on variables in the makefiles. At least this is = a “known limitation.”

2. = Configuration process does not check for openssl = and x11, which I believe are both required.

3. = APPEND_LIB doesn’t carry through to all = the makefiles.

My = openssl and x11 libraries are in non-standard locations (not in /usr/X11 = or /usr/openssl).

I’ve provided = three very trivial patches that I hope will be more illustrative than my = typing, but they are probably not production grade. =

I applied them prior to = configuration and got a clean build.

Best = regards,

David

------=_NextPart_001_00D6_01CED894.EE52B440-- ------=_NextPart_000_00D5_01CED894.EE528D30 Content-Type: application/octet-stream; name="xen-makefile.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xen-makefile.patch" --- tools/blktap/drivers/Makefile 2013-11-03 11:11:39.935857730 -0500=0A= +++ tools/blktap/drivers/Makefile.new 2013-11-03 11:10:55.765494493 -0500=0A= @@ -57,16 +57,16 @@=0A= all: $(IBIN) qcow-util=0A= =0A= blktapctrl: $(BLKTAB-OBJS-y)=0A= - $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_blktapctrl)=0A= + $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_blktapctrl) $(APPEND_LDFLAGS)=0A= =0A= tapdisk: tapdisk.o $(BLK-OBJS-y)=0A= - $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_img)=0A= + $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_img) $(APPEND_LDFLAGS)=0A= =0A= .PHONY: qcow-util=0A= qcow-util: img2qcow qcow2raw qcow-create=0A= =0A= img2qcow qcow2raw qcow-create: %: %.o $(BLK-OBJS-y)=0A= - $(CC) $(LDFLAGS) -o $* $^ $(LDLIBS_img)=0A= + $(CC) $(LDFLAGS) -o $* $^ $(LDLIBS_img) $(APPEND_LDFLAGS)=0A= =0A= install: all=0A= $(INSTALL_PROG) $(IBIN) $(QCOW_UTIL) $(VHD_UTIL) $(DESTDIR)$(SBINDIR)=0A= ------=_NextPart_000_00D5_01CED894.EE528D30 Content-Type: application/octet-stream; name="xen-makefile2.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xen-makefile2.patch" --- tools/qemu-xen-traditional/rules.mak 2013-11-03 12:01:27.320113656 = -0500=0A= +++ tools/qemu-xen-traditional/rules.mak.new 2013-11-03 = 11:55:00.186984301 -0500=0A= @@ -8,7 +8,7 @@=0A= %.o: %.m=0A= $(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<," OBJC = $(TARGET_DIR)$@")=0A= =0A= -LINK =3D $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS)," LINK = $(TARGET_DIR)$@")=0A= +LINK =3D $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ = $(APPEND_LDFLAGS) $(LIBS)," LINK $(TARGET_DIR)$@")=0A= =0A= %$(EXESUF): %.o=0A= $(LINK)=0A= ------=_NextPart_000_00D5_01CED894.EE528D30 Content-Type: application/octet-stream; name="xen-makefile3.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xen-makefile3.patch" --- tools/qemu-xen/rules.mak 2013-10-10 10:20:18.000000000 -0400=0A= +++ tools/qemu-xen/rules.mak.new 2013-11-03 12:44:47.681054056 -0500=0A= @@ -31,7 +31,8 @@=0A= %.o: %.m=0A= $(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) = $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," OBJC $(TARGET_DIR)$@")=0A= =0A= -LINK =3D $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) = -o $@ $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(LIBS)," LINK = $(TARGET_DIR)$@")=0A= +APPEND_LDFLAGS +=3D -L/opt/openssl/lib -L/usr/x11/lib=0A= +LINK =3D $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) = -o $@ $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(APPEND_LDFLAGS) = $(LIBS)," LINK $(TARGET_DIR)$@")=0A= =0A= %$(EXESUF): %.o=0A= $(call LINK,$^)=0A= ------=_NextPart_000_00D5_01CED894.EE528D30 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ------=_NextPart_000_00D5_01CED894.EE528D30--