Re: f2fs: reorganize f2fs_map_blocks

[Chao Yu <chao2.yu@samsung.com>]

Hi Dan,

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, September 22, 2015 12:25 AM
> To: chao2.yu@samsung.com
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Subject: re: f2fs: reorganize f2fs_map_blocks
> 
> Hello Chao Yu,
> 
> The patch bce86a6c64a7: "f2fs: reorganize f2fs_map_blocks" from Sep
> 11, 2015, leads to the following static checker warning:
> 
> 	fs/f2fs/data.c:653 f2fs_map_blocks()
> 	warn: was || intended here instead of &&?
> 
> fs/f2fs/data.c
>    650          if (maxblocks > map->m_len) {
>    651                  block_t blkaddr = datablock_addr(dn.node_page, dn.ofs_in_node);
>    652
>    653                  if (blkaddr == NEW_ADDR && blkaddr == NULL_ADDR) {
>                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Impossible condition.

Thanks for pointing it out. :)

My v2 patch sent several days ago has fixed that issue.

Thanks,


------------------------------------------------------------------------------