All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Madhusudhan Chikkature" <madhu.cr@ti.com>
To: me@felipebalbi.com, Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
	tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH]OMAP HDQ driver ioremap changes
Date: Tue, 23 Sep 2008 10:22:41 +0530	[thread overview]
Message-ID: <00da01c91d38$38421a00$LocalHost@wipultra1303> (raw)
In-Reply-To: 20080923022419.GE10156@frodo


----- Original Message ----- 
From: "Felipe Balbi" <me@felipebalbi.com>
To: "Evgeniy Polyakov" <johnpol@2ka.mipt.ru>
Cc: "Felipe Balbi" <felipe.balbi@nokia.com>; "ext Madhusudhan Chikkature" <madhu.cr@ti.com>; <tony@atomide.com>; <linux-omap@vger.kernel.org>
Sent: Tuesday, September 23, 2008 7:54 AM
Subject: Re: [PATCH]OMAP HDQ driver ioremap changes


> On Tue, Sep 23, 2008 at 12:14:00AM +0400, Evgeniy Polyakov wrote:
>> On Mon, Sep 22, 2008 at 05:37:41PM +0300, Felipe Balbi (felipe.balbi@nokia.com) wrote:
>> > +/*
>> > + * Used to control the call to omap_hdq_get and omap_hdq_put.
>> > + * HDQ Protocol: Write the CMD|REG_address first, followed by
>> > + * the data wrire or read.
>> > + */
>> > +static int init_trans;
>> 
>> This variable is not protected against simultaneous master's access
>> afaics, isn't it possible to have multiple w1 masters on given board?
> 
> Don't know much about 1-wire. Someone else should answer that. But I
> suppose we should protect it, yeah.

We can not test that scenario on our board. But I guess we should protect it as 1-Wire protocol supports multiple access.

Regards,
Madhu
> 
> -- 
> balbi
> 
>

  reply	other threads:[~2008-09-23  4:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 10:15 [PATCH]OMAP HDQ driver ioremap changes Madhusudhan Chikkature
2008-09-22 13:06 ` Evgeniy Polyakov
2008-09-22 13:13   ` Madhusudhan Chikkature
2008-09-22 13:27     ` Felipe Balbi
2008-09-22 13:31       ` Madhusudhan Chikkature
2008-09-22 13:38         ` Felipe Balbi
2008-09-22 14:37         ` Felipe Balbi
2008-09-22 20:14           ` Evgeniy Polyakov
2008-09-23  2:24             ` Felipe Balbi
2008-09-23  4:52               ` Madhusudhan Chikkature [this message]
2008-09-23  6:52                 ` Evgeniy Polyakov
2008-09-23  4:37           ` Madhusudhan Chikkature
2008-09-23 10:57             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00da01c91d38$38421a00$LocalHost@wipultra1303' \
    --to=madhu.cr@ti.com \
    --cc=felipe.balbi@nokia.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.