All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hamman <joe.hamman@embeddedspecialties.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] Updated patch to add SBC8641D
Date: Mon, 6 Aug 2007 11:25:53 -0500	[thread overview]
Message-ID: <00e101c7d846$75de1ef0$6d00a8c0@ESIDT> (raw)
In-Reply-To: <20070806153904.56D103535DD@atlas.denx.de>


Hi Wolfgang,

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de]
> Sent: Monday, August 06, 2007 10:39 AM
> To: joe.hamman at embeddedspecialties.com
> Cc: jdl at freescale.com; u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH 1/2] Updated patch to add SBC8641D
> 
> In message <1186410455.22362.7.camel@server> you wrote:
> > Add support for Wind River's SBC8641D reference board.
> >
> > Resend to add fixes per JDL.
> >
> > Signed-off by: Joe Hamman <joe.hamman@embeddedspecialties.com>
> 
> NAK.
> 
> I  reject  this  patch  because  you  are  modifying   global   files
> (config.mk)  without  mentioning  it at all, and in a way that is (1)
> unrelated to your patch and (2) contra-rpoductive  on  most  systems.
> Please don't try again to sneak in code changes this way.

Thanks for catching this.  It was left over from a debugging session and I
never intended it to be submitted.

I'll be more careful in the future.

Regards,
Joe

  reply	other threads:[~2007-08-06 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 14:27 [U-Boot-Users] [PATCH 1/2] Updated patch to add SBC8641D Joe Hamman
2007-08-06 15:39 ` Wolfgang Denk
2007-08-06 16:25   ` Joe Hamman [this message]
2007-08-06 16:51 ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00e101c7d846$75de1ef0$6d00a8c0@ESIDT' \
    --to=joe.hamman@embeddedspecialties.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.