Re: Error compiling with CONFIG_PROFILING (xenoprof)

["Michael Paesold" <mpaesold@gmx.at>]

Keir Fraser wrote:
> On 10 Apr 2006, at 10:45, Michael Paesold wrote:
>>
>> Here is the build error:
>> arch/i386/oprofile/xenoprof.c:315: error: unknown field `set_active' 
>> specified in initializer
>> arch/i386/oprofile/xenoprof.c:315: warning: initialization from 
>> incompatible pointer type
>> make[1]: *** [arch/i386/oprofile/xenoprof.o] Error 1
>> make: *** [arch/i386/oprofile] Error 2
>>
>>
>> That is from linux 2.6.16.1 with xen patched into the kernel from "make 
>> mkpatches". I can supply the kernel config as well as my kernel source 
>> RPM to recreate the problem, if that helps.
>
> You're missing the extra patch in file 
> patches/linux-2.6.16/xenoprof-generic.patch.

Thanks! I had missed that patch when updating to that changeset.

> 'make mkpatches' should be incorporating the extra patches from 
> patches/linux-2.6.16 -- if it isn't then it needs fixing to do so.

I think "make mkpatches" is correct, but I missed the additional patch. To 
use the patch from mkpatches and apply them to a vanilla kernel, one also 
needs to apply all patches from patches/linux-2.6.16. "make mkpatches" 
creates diffs between vanilla+patches/linux-2.6.16 and 
xenified+patches/linux-2.6.16).

Best Regards,
Michael Paesold