Re: [PATCH] nvmem: imx-ocotp: Use helper function devm_clk_get_enabled()

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/06/2025 05:23, Huan Tang wrote:
> Use devm_clk_get_enabled() helper to simplify code.
> 
> Signed-off-by: Huan Tang <tanghuan@vivo.com>
> ---
>  drivers/nvmem/imx-ocotp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
> index 79dd4fda0329..ce5970ba4033 100644
> --- a/drivers/nvmem/imx-ocotp.c
> +++ b/drivers/nvmem/imx-ocotp.c
> @@ -605,7 +605,7 @@ static int imx_ocotp_probe(struct platform_device *pdev)
>  	if (IS_ERR(priv->base))
>  		return PTR_ERR(priv->base);
>  
> -	priv->clk = devm_clk_get(dev, NULL);
> +	priv->clk = devm_clk_get_enabled(dev, NULL);

This is just confusing or even wrong. You do not understand the code,
just blindly do some changes pointed by scripting.

NAK.


>  


Best regards,
Krzysztof