From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Diana Craciun' <diana.craciun@freescale.com>,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH v3 3/5] kvm_arm: Pass requester ID to MSI routing functions
Date: Mon, 30 Nov 2015 09:41:50 +0300 [thread overview]
Message-ID: <00e801d12b3a$320522f0$960f68d0$@samsung.com> (raw)
In-Reply-To: <CAFEAcA-LuidMgNo6-z1fdR96aCptWt8Zzei8hH-kcgQE7c3vPw@mail.gmail.com>
Hello!
> > + route->u.msi.devid = pci_requester_id(dev);
> > + }
>
> Is there anything that would go wrong if we just always set
> the u.msi.devid and the VALID_DEVID flag? (ie do we need the
> kvm_arm_msi_use_devid bool?)
Current kernels always make sure that flags == 0, or they simply return -EINVAL. Therefore, for backwards compatibility we set the flag only if we know that we need it.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-11-30 6:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 10:13 [Qemu-devel] [RFC PATCH v3 0/5] vITS support Pavel Fedin
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 1/5] hw/intc: Implement ITS base class Pavel Fedin
2015-11-27 15:35 ` Peter Maydell
2015-11-30 7:09 ` Pavel Fedin
2015-11-29 8:10 ` Shannon Zhao
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 2/5] kernel: Add vGICv3 ITS definitions Pavel Fedin
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 3/5] kvm_arm: Pass requester ID to MSI routing functions Pavel Fedin
2015-11-27 15:45 ` Peter Maydell
2015-11-30 6:41 ` Pavel Fedin [this message]
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 4/5] kvm_arm: Implement support for ITS emulation by KVM Pavel Fedin
2015-11-27 15:47 ` Peter Maydell
2015-11-24 10:13 ` [Qemu-devel] [RFC PATCH v3 5/5] arm/virt: Add ITS to the virt board Pavel Fedin
2015-11-27 16:18 ` Peter Maydell
2015-11-28 3:55 ` Shannon Zhao
2016-06-28 6:41 ` [Qemu-devel] [RFC PATCH v3 0/5] vITS support Auger Eric
2016-06-28 8:25 ` Christoffer Dall
2016-06-29 6:45 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00e801d12b3a$320522f0$960f68d0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=diana.craciun@freescale.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.