From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH 08/12] f2fs: introduce a shrinker for mounted fs Date: Tue, 30 Jun 2015 11:43:29 +0800 Message-ID: <00e901d0b2e7$0fa893c0$2ef9bb40$@samsung.com> References: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> <1435603176-63219-8-git-send-email-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Z9mTM-0007Hs-1j for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Jun 2015 03:44:36 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) id 1Z9mTK-0003wh-3m for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Jun 2015 03:44:36 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQQ00LNYNQ26R30@mailout2.samsung.com> for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Jun 2015 12:44:26 +0900 (KST) In-reply-to: <1435603176-63219-8-git-send-email-jaegeuk@kernel.org> Content-language: zh-cn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: 'Jaegeuk Kim' Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, June 30, 2015 2:40 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 08/12] f2fs: introduce a shrinker for mounted fs > > This patch introduces a shrinker targeting to reduce memory footprint consumed > by a number of in-memory f2fs data structures. > > In addition, it newly adds: > - sbi->umount_mutex to avoid data races on shrinker and put_super > - sbi->shruinker_run_no to not revisit objects > > Noteh that the basic implementation was copied from fs/btrfs/shrinker.c Great! Good to see it's being implemented in f2fs. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu [snip] > @@ -1406,6 +1425,9 @@ static int __init init_f2fs_fs(void) > err = f2fs_init_crypto(); > if (err) > goto free_kset; > + > + register_shrinker(&f2fs_shrinker_info); This function can fail due to no memory, please check the return value here. Thanks, ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753436AbbF3Doi (ORCPT ); Mon, 29 Jun 2015 23:44:38 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:36156 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbF3Do2 (ORCPT ); Mon, 29 Jun 2015 23:44:28 -0400 X-AuditID: cbfee61b-f79416d0000014c0-c7-5592109a578a From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1435603176-63219-1-git-send-email-jaegeuk@kernel.org> <1435603176-63219-8-git-send-email-jaegeuk@kernel.org> In-reply-to: <1435603176-63219-8-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH 08/12] f2fs: introduce a shrinker for mounted fs Date: Tue, 30 Jun 2015 11:43:29 +0800 Message-id: <00e901d0b2e7$0fa893c0$2ef9bb40$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQIP2ZWuDS0opyTuw8lIx+7z0YD0SgHvuxu2nTaZg3A= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t9jAd1ZApNCDRrWyFo8WT+L2eLSIneL PXtPslhc3jWHzYHFY9OqTjaP3Qs+M3l83iQXwBzFZZOSmpNZllqkb5fAlXF4aw9jwReOinv3 17A0MM5n72Lk5JAQMJFYffEHK4QtJnHh3nq2LkYuDiGBRYwSO3tXMEI4rxgluuctYQapYhNQ kVje8Z8JxBYRUJPo3TcFzGYWyJSY0P8CbKqQQLXEt/btjCA2p4CzxIuuXWwgtrCAv8StjXvA 5rAIqEocutULVs8rYCmxu20zM4QtKPFj8j0WiJlaEut3HoeaLy+xec1bZohLFSR2nH3NCHGD lcSxi2+YIWrEJTYeucUygVFoFpJRs5CMmoVk1CwkLQsYWVYxiqYWJBcUJ6XnGukVJ+YWl+al 6yXn525iBIf+M+kdjKsaLA4xCnAwKvHwFrJNChViTSwrrsw9xCjBwawkwssUOzFUiDclsbIq tSg/vqg0J7X4EKM0B4uSOO/JfJ9QIYH0xJLU7NTUgtQimCwTB6dUA6Pfruy6wAT3umNec3TO H1Z5r7pPvYLl5N6iQm2B/TPuPBI+OKtkwdy8NzrTMtRZVLKEr7CeVL/g42HKfbGyMOV/u9fF aO654WzGN1KvThSpOMvL+MjkTOTHimc3rkZXTHbxadNZzaE0Wf4c283PKdcyY7pu/17/lOVg brjtl8JrOeu1pk9/PkeJpTgj0VCLuag4EQCFUiogeQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, June 30, 2015 2:40 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 08/12] f2fs: introduce a shrinker for mounted fs > > This patch introduces a shrinker targeting to reduce memory footprint consumed > by a number of in-memory f2fs data structures. > > In addition, it newly adds: > - sbi->umount_mutex to avoid data races on shrinker and put_super > - sbi->shruinker_run_no to not revisit objects > > Noteh that the basic implementation was copied from fs/btrfs/shrinker.c Great! Good to see it's being implemented in f2fs. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu [snip] > @@ -1406,6 +1425,9 @@ static int __init init_f2fs_fs(void) > err = f2fs_init_crypto(); > if (err) > goto free_kset; > + > + register_shrinker(&f2fs_shrinker_info); This function can fail due to no memory, please check the return value here. Thanks,