From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH WIP/RFC v2 6/6] nvme-rdma: use ib_client API to detect device removal
Date: Tue, 30 Aug 2016 10:57:53 -0500 [thread overview]
Message-ID: <00eb01d202d7$446f8870$cd4e9950$@opengridcomputing.com> (raw)
In-Reply-To: <d0bf0b9b-8f81-4d6b-4534-1fccb146e328@grimberg.me>
>
> >> Will this code work?
> >>
> >> mutex_lock(&nvme_rdma_ctrl_mutex);
> >> list_for_each_entry(ctrl, &nvme_rdma_ctrl_list, list) {
> >> if (ctrl->device->dev != ib_device)
> >> continue;
> >>
> >> __nvme_rdma_del_ctrl(ctrl);
> >> }
> >> mutex_unlock(&nvme_rdma_ctrl_mutex);
> >>
> >> flush_workqueue(nvme_rdma_wq);
> >
> > I'll try this. It is cleaner/easier to understand.
> >
> > I'm also moving the controller list to per-device as Christoph recommends.
>
> I'm still not sure if it's a real must. This will only save us the
> condition (as we'll get the device in the client data)
True, and your logic avoids the unlock/relock.
next prev parent reply other threads:[~2016-08-30 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 21:35 [PATCH WIP/RFC v2 0/6] nvme-rdma device removal fixes Steve Wise
2016-08-29 21:26 ` [PATCH WIP/RFC v2 1/6] iw_cxgb4: call dev_put() on l2t allocation failure Steve Wise
2016-08-29 21:26 ` [PATCH WIP/RFC v2 2/6] iw_cxgb4: block module unload until all ep resources are released Steve Wise
2016-08-29 21:27 ` [PATCH WIP/RFC v2 3/6] nvme_rdma: keep a ref on the ctrl during delete/flush Steve Wise
2016-08-29 21:28 ` [PATCH WIP/RFC v2 4/6] nvme-rdma: destroy nvme queue rdma resources on connect failure Steve Wise
2016-08-29 21:28 ` [PATCH WIP/RFC v2 5/6] nvme-rdma: add DELETING queue flag Sagi Grimberg
2016-08-29 21:35 ` [PATCH WIP/RFC v2 6/6] nvme-rdma: use ib_client API to detect device removal Steve Wise
2016-08-30 7:06 ` Christoph Hellwig
2016-08-30 14:05 ` Steve Wise
2016-08-30 15:44 ` Steve Wise
2016-08-30 15:46 ` Sagi Grimberg
2016-08-30 15:48 ` Steve Wise
2016-08-30 15:56 ` Sagi Grimberg
2016-08-30 15:57 ` Steve Wise [this message]
2016-08-30 16:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00eb01d202d7$446f8870$cd4e9950$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.