From: Markus Elfring <Markus.Elfring@web.de>
To: manushprajwal555@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sunil Goutham <sgoutham@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH 1/2] net: thunder_bgx: fix fwnode leak in bgx_init_of_phy()
Date: Sun, 23 Aug 2026 19:15:05 +0200 [thread overview]
Message-ID: <00ef4774-5155-4c32-a65f-4affcb52b620@web.de> (raw)
In-Reply-To: <20260823111231.372-1-manushprajwal555@gmail.com>
> If a child returned by device_for_each_child_node() is not backed by
> a device_node, to_of_node() returns NULL and the loop is aborted with
> a bare break, without releasing the reference on the current fwnode
> that device_for_each_child_node() took. Call fwnode_handle_put()
> before breaking out of the loop, mirroring the existing of_node_put()
> call a few lines below for the "lmac == bgx->max_lmac" exit path.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
https://elixir.bootlin.com/linux/v7.2/source/drivers/net/ethernet/cavium/thunder/thunder_bgx.c#L1466-L1531
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst?id=v7.2#n3
Would a cover letter be helpful also for the presented small “patch series”?
Regards,
Markus
next prev parent reply other threads:[~2026-08-23 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 11:12 [PATCH 1/2] net: thunder_bgx: fix fwnode leak in bgx_init_of_phy() manushprajwal
2026-08-23 17:15 ` Markus Elfring [this message]
2026-08-27 15:56 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-08-27 18:38 Manush Prajwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ef4774-5155-4c32-a65f-4affcb52b620@web.de \
--to=markus.elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manushprajwal555@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.