From mboxrd@z Thu Jan 1 00:00:00 1970 From: swise@opengridcomputing.com (Steve Wise) Date: Tue, 25 Oct 2016 11:04:55 -0500 Subject: [PATCH v3 6/6] rds_rdma: log the connection reject message In-Reply-To: <928b6e33-992b-8b88-e224-224f19566623@oracle.com> References: <21c48d771ab8a9d37ec19ea5f7a48ed5b84c8984.1477336045.git.swise@opengridcomputing.com> <928b6e33-992b-8b88-e224-224f19566623@oracle.com> Message-ID: <00f201d22ed9$86ebb1a0$94c314e0$@opengridcomputing.com> > -----Original Message----- > From: Santosh Shilimkar [mailto:santosh.shilimkar at oracle.com] > Sent: Tuesday, October 25, 2016 10:52 AM > To: Steve Wise; dledford at redhat.com; sean.hefty at intel.com > Cc: linux-rdma at vger.kernel.org; bart.vanassche at sandisk.com; linux- > nvme at lists.infradead.org; sagi at grimberg.me; hch at lst.de; axboe at fb.com > Subject: Re: [PATCH v3 6/6] rds_rdma: log the connection reject message > > On 10/24/2016 12:07 PM, Steve Wise wrote: > > Signed-off-by: Steve Wise > > --- > > net/rds/rdma_transport.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c > > index 345f090..6bd2814 100644 > > --- a/net/rds/rdma_transport.c > > +++ b/net/rds/rdma_transport.c > > @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id > *cm_id, > > trans->cm_connect_complete(conn, event); > > break; > > > > + case RDMA_CM_EVENT_REJECTED: > > + rdsdebug("Connection rejected: %s\n", > > + rdma_reject_msg(cm_id, event->status)); > For current code above is fine but I will need the other helper > while adding few connection cases where ARI field carries information > for the reason for the reject. > > I assume, rdma_consumer_reject_data() is meant to be used for that ? Yep. You can see the nvme_rdma patch in this series for an example. > > The patch looks fine to me. > FWIW, Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH v3 6/6] rds_rdma: log the connection reject message Date: Tue, 25 Oct 2016 11:04:55 -0500 Message-ID: <00f201d22ed9$86ebb1a0$94c314e0$@opengridcomputing.com> References: <21c48d771ab8a9d37ec19ea5f7a48ed5b84c8984.1477336045.git.swise@opengridcomputing.com> <928b6e33-992b-8b88-e224-224f19566623@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <928b6e33-992b-8b88-e224-224f19566623-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Santosh Shilimkar' , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org, hch-jcswGhMUV9g@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org List-Id: linux-rdma@vger.kernel.org > -----Original Message----- > From: Santosh Shilimkar [mailto:santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org] > Sent: Tuesday, October 25, 2016 10:52 AM > To: Steve Wise; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org; linux- > nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org; hch-jcswGhMUV9g@public.gmane.org; axboe-b10kYP2dOMg@public.gmane.org > Subject: Re: [PATCH v3 6/6] rds_rdma: log the connection reject message > > On 10/24/2016 12:07 PM, Steve Wise wrote: > > Signed-off-by: Steve Wise > > --- > > net/rds/rdma_transport.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c > > index 345f090..6bd2814 100644 > > --- a/net/rds/rdma_transport.c > > +++ b/net/rds/rdma_transport.c > > @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id > *cm_id, > > trans->cm_connect_complete(conn, event); > > break; > > > > + case RDMA_CM_EVENT_REJECTED: > > + rdsdebug("Connection rejected: %s\n", > > + rdma_reject_msg(cm_id, event->status)); > For current code above is fine but I will need the other helper > while adding few connection cases where ARI field carries information > for the reason for the reject. > > I assume, rdma_consumer_reject_data() is meant to be used for that ? Yep. You can see the nvme_rdma patch in this series for an example. > > The patch looks fine to me. > FWIW, Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html