From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>, <horms@kernel.org>,
<mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next 1/5] net: wangxun: add flow control support
Date: Thu, 23 Nov 2023 17:20:37 +0800 [thread overview]
Message-ID: <00f701da1dee$51bfb0b0$f53f1210$@trustnetic.com> (raw)
In-Reply-To: <6218df6e-db11-4640-a296-946088d32916@lunn.ch>
On Thursday, November 23, 2023 12:15 AM, Andrew Lunn wrote:
> > + /* Calculate max LAN frame size */
> > + link = dev->mtu + ETH_HLEN + ETH_FCS_LEN + WX_ETH_FRAMING;
> > + tc = link;
> > +
> > + /* Calculate delay value for device */
> > + dv_id = WX_DV(link, tc);
>
> That looks odd. tc == link. So why pass both? Or is it a typo?
This is because I've temporarily removed the FCOE related code,
as something to support later. So now tc == link, which looks odd.
next prev parent reply other threads:[~2023-11-23 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 10:22 [PATCH net-next 0/5] Implement more ethtool_ops for Wangxun Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 1/5] net: wangxun: add flow control support Jiawen Wu
2023-11-22 16:15 ` Andrew Lunn
2023-11-22 16:30 ` Russell King (Oracle)
2023-11-22 17:24 ` Andrew Lunn
2023-11-22 17:26 ` Russell King (Oracle)
2023-11-23 9:20 ` Jiawen Wu [this message]
2023-11-22 10:22 ` [PATCH net-next 2/5] net: wangxun: add ethtool_ops for ring parameters Jiawen Wu
2023-11-22 16:24 ` Andrew Lunn
2023-11-23 9:25 ` Jiawen Wu
2023-11-23 15:14 ` Andrew Lunn
2023-11-30 3:32 ` Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 3/5] net: wangxun: add coalesce options support Jiawen Wu
2023-11-22 10:22 ` [PATCH net-next 4/5] net: wangxun: add ethtool_ops for channel number Jiawen Wu
2023-11-22 16:35 ` Andrew Lunn
2023-11-22 10:22 ` [PATCH net-next 5/5] net: wangxun: add ethtool_ops for msglevel Jiawen Wu
2023-11-22 16:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00f701da1dee$51bfb0b0$f53f1210$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.