From: "Kyungmin Park" <kmpark@infradead.org>
To: <dedekind@infradead.org>, "'David Woodhouse'" <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: RE: [PATCH try 2] MTD: OneNAND: fix numerous races
Date: Thu, 27 Sep 2007 08:50:48 +0900 [thread overview]
Message-ID: <00fa01c80098$152a45a0$e1ac580a@swcenter.sec.samsung.co.kr> (raw)
In-Reply-To: <1190388606.14370.212.camel@sauron>
Hi,
Sorry for late replying.
Look good to me except one typo.
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> @@ -2052,7 +2063,12 @@ static int do_otp_write(struct mtd_info *mtd, loff_t from, size_t len,
> this->command(mtd, ONENAND_CMD_OTP_ACCESS, 0, 0);
> this->wait(mtd, FL_OTPING);
>
> - ret = mtd->write(mtd, from, len, retlen, pbuf);
> + ops.len = len;
> + ops.ooblen = 0;
> + ops.databuf = pbuf;
It should be ops.datbuf.
> + ops.oobbuf = NULL;
> + ret = onenand_write_ops_nolock(mtd, to, &ops);
> + *retlen = ops.retlen;
next prev parent reply other threads:[~2007-09-26 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 13:46 [PATCH] MTD: OneNAND: fix numerous races Artem Bityutskiy
2007-09-21 13:56 ` Artem Bityutskiy
2007-09-21 15:30 ` [PATCH try 2] " Artem Bityutskiy
2007-09-26 23:50 ` Kyungmin Park [this message]
2007-09-27 8:55 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fa01c80098$152a45a0$e1ac580a@swcenter.sec.samsung.co.kr' \
--to=kmpark@infradead.org \
--cc=dedekind@infradead.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.