From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZEuD7-0003Uo-Q9
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:01:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZEuD4-00005F-F7
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:01:01 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:60994)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZEuD4-0008P6-9e
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:00:58 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout2.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NRG006W0U5I6Z00@mailout2.w1.samsung.com> for
	qemu-devel@nongnu.org; Tue, 14 Jul 2015 08:00:54 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1436276959.git.p.fedin@samsung.com>
	<338d7558e721238a4cd6b461e7824d44f2361d40.1436276959.git.p.fedin@samsung.com>
	<559EA76C.40701@linaro.org>
In-reply-to: <559EA76C.40701@linaro.org>
Date: Tue, 14 Jul 2015 10:00:52 +0300
Message-id: <00fe01d0be02$d34c7640$79e562c0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Auger' <eric.auger@linaro.org>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'Christoffer Dall' <christoffer.dall@linaro.org>, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

 Hi!

> /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:565:5: error:
> passing argument 2 of 'qdev_init_gpio_in' from incompatible pointer type
> [-Werror]
>      qdev_init_gpio_in(dev, kvm_arm_gic_set_irq, i);
> 
> also
> 
> /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:90:13: error:
> 'kvm_arm_gicv2_set_irq' defined but not used [-Werror=unused-function]
>  static void kvm_arm_gicv2_set_irq(void *opaque, int irq, int level)

 Ooops, i have occasionally missed this during rebase and conflict fixing. Actually it's a big bug,
and the code would not even work. :( Thank you for spotting this. In my master this issue is not
present. Fixing and will respin today.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia