From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Date: Thu, 30 Nov 2017 16:41:50 +0000 Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static Message-Id: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> List-Id: References: <20171130133006.19699-1-colin.king@canonical.com> In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Colin King' , 'Steve Wise' , 'Doug Ledford' , 'Jason Gunthorpe' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org > > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Looks correct. This fixes a recent commit. Reviewed-by: Steve Wise Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning") Thanks, Steve. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static Date: Thu, 30 Nov 2017 10:41:50 -0600 Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> References: <20171130133006.19699-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Colin King' , 'Steve Wise' , 'Doug Ledford' , 'Jason Gunthorpe' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Looks correct. This fixes a recent commit. Reviewed-by: Steve Wise Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning") Thanks, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbdK3Qrb convert rfc822-to-8bit (ORCPT ); Thu, 30 Nov 2017 11:47:31 -0500 Received: from opengridcomputing.com ([70.118.0.34]:34300 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbdK3Qr2 (ORCPT ); Thu, 30 Nov 2017 11:47:28 -0500 X-Greylist: delayed 341 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Nov 2017 11:47:27 EST From: "Steve Wise" To: "'Colin King'" , "'Steve Wise'" , "'Doug Ledford'" , "'Jason Gunthorpe'" , Cc: , , References: <20171130133006.19699-1-colin.king@canonical.com> In-Reply-To: <20171130133006.19699-1-colin.king@canonical.com> Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static Date: Thu, 30 Nov 2017 10:41:50 -0600 Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Content-Language: en-us Thread-Index: AQH3RTnGEnie/UjMnvLYPYviJRRPY6LlaRfw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > From: Colin Ian King > > The pointer reg_workq is local to the source and does not need to be > in global scope, so make it static. > > Cleans up sparse warning: > drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Looks correct. This fixes a recent commit. Reviewed-by: Steve Wise Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning") Thanks, Steve.