From: Pavel Fedin <p.fedin@samsung.com>
To: 'Cornelia Huck' <cornelia.huck@de.ibm.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
'Paolo Bonzini' <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "'Michael S. Tsirkin'" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions
Date: Thu, 15 Oct 2015 14:59:13 +0300 [thread overview]
Message-ID: <00ff01d10740$e9786d20$bc694760$@samsung.com> (raw)
In-Reply-To: <20151015134115.0a7b0b74.cornelia.huck@de.ibm.com>
Hello!
> Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well?
> Currently, the only implementer of this function (s390x) does not need
> it; but it shouldn't hurt?
Yes, it shouldn't. I didn't pass it there exactly because of this reason. However, &kroute is also passed to this function, so
setting ARM-specific data could be moved there. I mean this repeating sequence (see vITS RFC 4/6 -
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg07075.html):
--- cut ---
kroute.flags = kvm_msi_flags;
if (kroute.flags & KVM_MSI_VALID_DEVID) {
kroute.u.msi.devid = pci_requester_id(dev);
}
--- cut ---
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-15 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 11:05 [Qemu-devel] [PATCH v5 0/3] Make KVM/MSI code device-ID-aware Pavel Fedin
2015-10-15 11:05 ` [Qemu-devel] [PATCH v5 1/3] kvm: Make KVM_CAP_SIGNAL_MSI globally available Pavel Fedin
2015-10-15 11:05 ` [Qemu-devel] [PATCH v5 2/3] hw/pci: Introduce pci_requester_id() Pavel Fedin
2015-10-15 13:11 ` Michael S. Tsirkin
2015-10-15 13:28 ` Pavel Fedin
2015-10-18 8:29 ` Michael S. Tsirkin
2015-10-15 11:05 ` [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions Pavel Fedin
2015-10-15 11:41 ` Cornelia Huck
2015-10-15 11:59 ` Pavel Fedin [this message]
2015-10-18 8:31 ` [Qemu-devel] [PATCH v5 0/3] Make KVM/MSI code device-ID-aware Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ff01d10740$e9786d20$bc694760$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.