From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7CAC04FE1 for ; Mon, 14 Aug 2023 04:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233204AbjHNEw7 (ORCPT ); Mon, 14 Aug 2023 00:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbjHNEwu (ORCPT ); Mon, 14 Aug 2023 00:52:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F5EBE63; Sun, 13 Aug 2023 21:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691988769; x=1723524769; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=Qg68hDQyVU5rdKRTZEFIz/aR7ze3OEvBkBX64vYD6UM=; b=BboZ8y8i+tV/wWdnUs7VgdSrBRgkRMvZCNcR6vXEXtuYsw0Lep9gHcb2 rRZ3Jmo30qGRGfTcxZ8Ab3R5QBzzXI6yrmuyCoT80t19g87W8gtVgquOj I9fTLrQtD1+ryL1g4o61oL/AQykAfXg3I9O+jHTwzhteUPcQGCUHAtVJl B6rOaz287M7wXWUkeuDaI4UjxWccBEggQaP9fHK9Gy0PYimWloLQ0HyHB g4rLG3adLgtMOMTilk5y7L/2/ma71ysZt8+bq5wuWAK1XNqEtlGgzLlVe KBkIiDsh9/STnjSxfkNSWOLcC/FGMnu1PHm/ZSiGMlwKf3gZuutato2Aq Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="356924284" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="356924284" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="907098556" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="907098556" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:37 -0700 Message-ID: <0104371e-a824-8ace-eae3-da90df285c41@linux.intel.com> Date: Mon, 14 Aug 2023 12:52:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 10/25] iommu/exynos: Implement an IDENTITY domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2023/8/3 8:07, Jason Gunthorpe wrote: > What exynos calls exynos_iommu_detach_device is actually putting the iommu > into identity mode. > > Move to the new core support for ARM_DMA_USE_IOMMU by defining > ops->identity_domain. > > Tested-by: Marek Szyprowski > Acked-by: Marek Szyprowski > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/exynos-iommu.c | 66 +++++++++++++++++------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c275fe71c4db32..5e12b85dfe8705 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -24,6 +24,7 @@ > > typedef u32 sysmmu_iova_t; > typedef u32 sysmmu_pte_t; > +static struct iommu_domain exynos_identity_domain; Is there a conflict between above and below? [...] > > +static struct iommu_domain_ops exynos_identity_ops = { > + .attach_dev = exynos_iommu_identity_attach, > +}; > + > +static struct iommu_domain exynos_identity_domain = { here. Both define the same. > + .type = IOMMU_DOMAIN_IDENTITY, > + .ops = &exynos_identity_ops, > +}; Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22FBEC04A6A for ; Mon, 14 Aug 2023 04:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PKxD80Ie4cYeMZUj2AQ94IqdqoMglZ6OmRlD9i/6gVI=; b=BfO81XFg4+5eT6 JkwKCtzS3IDuhE61v0a15c/2/2M+JsMvWm2LlGfW1pZTNDRorw77C04M4X78lSpUiFSdSOx0sl3c5 UMjM3S77gex3s/BdnA3/y3EAWcQ0f7j+ktiK4H+9Ti8UoUBch09Pr06Kg62SFyRUFHCVv2EDZs8KK bCW55nojN7Zf5dcqAS0QlvUsh+vZsbYkR1lJizFOvJRMd8IQ2oBFrM//W67vZsMDdsd8VDkBnjsd+ HyIAwI+3Co2w5E4Ea8McLXQ5rJ2GGRyu7CRFovSXKfZEZG1MYN3tA0M01Lo4Kh86zMKRYV8TgE1pp BH8H27Ly0ZdqZNKqIhyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVPZV-00G9Tg-19; Mon, 14 Aug 2023 04:52:53 +0000 Received: from mgamail.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVPZS-00G9SA-1O; Mon, 14 Aug 2023 04:52:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691988770; x=1723524770; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=Qg68hDQyVU5rdKRTZEFIz/aR7ze3OEvBkBX64vYD6UM=; b=cw/2FXNFpAuLJbDqonehrR9olyKM+w6ngfRG3HLUudzgkzg73c9pfGBB yN+tD68O094jZviCDLSP7z7o/Gm+aVW+TZ2qSSvDfk7wseTBTGUTSS8QR Bz6f1iZAYZa65T/McRfcGJU6AdWfLGLDfSUzUV5+/QubtyLLNLltMnNoF FfpIv4Ik3A9rgFvWgvuxLZCCYgBTfJ0kGYsNbf8cu0eJb1yxdM91nh1HE cX0PETGA/atI1ZjDw6oXvDn0ynEBrqUXL02hlppDtIsx4lODrK3uz25Bb TbAknxNSbREcocHf4qaI+4U3xGm6u+7FilucowpXx48t/DqBCU6BxNYX7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="356924289" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="356924289" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="907098556" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="907098556" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:37 -0700 Message-ID: <0104371e-a824-8ace-eae3-da90df285c41@linux.intel.com> Date: Mon, 14 Aug 2023 12:52:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 10/25] iommu/exynos: Implement an IDENTITY domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230813_215250_511657_D6E11338 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 2023/8/3 8:07, Jason Gunthorpe wrote: > What exynos calls exynos_iommu_detach_device is actually putting the iommu > into identity mode. > > Move to the new core support for ARM_DMA_USE_IOMMU by defining > ops->identity_domain. > > Tested-by: Marek Szyprowski > Acked-by: Marek Szyprowski > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/exynos-iommu.c | 66 +++++++++++++++++------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c275fe71c4db32..5e12b85dfe8705 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -24,6 +24,7 @@ > > typedef u32 sysmmu_iova_t; > typedef u32 sysmmu_pte_t; > +static struct iommu_domain exynos_identity_domain; Is there a conflict between above and below? [...] > > +static struct iommu_domain_ops exynos_identity_ops = { > + .attach_dev = exynos_iommu_identity_attach, > +}; > + > +static struct iommu_domain exynos_identity_domain = { here. Both define the same. > + .type = IOMMU_DOMAIN_IDENTITY, > + .ops = &exynos_identity_ops, > +}; Best regards, baolu _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC33EC001B0 for ; Mon, 14 Aug 2023 04:53:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=CSy+He6I; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RPMVf2h2Sz30PY for ; Mon, 14 Aug 2023 14:53:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=CSy+He6I; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.126; helo=mgamail.intel.com; envelope-from=baolu.lu@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RPMTg6FSKz2yVs for ; Mon, 14 Aug 2023 14:52:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691988776; x=1723524776; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=Qg68hDQyVU5rdKRTZEFIz/aR7ze3OEvBkBX64vYD6UM=; b=CSy+He6I85Y0POYrU07Tjk902OB8qdMROVBjYaYT1WFfOjubewt0h8FM oCDN/J7BYZqSJEkwjwX0YJsfjsUcphTgZ+eJCw3UhaLyGaSc2t2xfRNQn DEFndIsukM+Cb7kXO9M1uZW6Zz0NJlF23uc/E2yX8MVTuS0diGhY/CXD9 1zpC6bS3iKpDmK+wDY8Qc2IBO/TDfibzMMIy/37DmhuhDR8JTd2W9fnuS jzSeFDaD1BiubTaB2I9430UnBsuK2YicXOr9f0dQI1cDgwgjiuiFQCYHN oR6FJ9Q9FZ7jYn8kktLYL5cbgfflifkk2cSBrBn3UPRY+7aT6kzw7EdIm A==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="356924298" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="356924298" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="907098556" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="907098556" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:37 -0700 Message-ID: <0104371e-a824-8ace-eae3-da90df285c41@linux.intel.com> Date: Mon, 14 Aug 2023 12:52:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 10/25] iommu/exynos: Implement an IDENTITY domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , Niklas Schnelle , Steven Price , Nicolin Chen , Dmitry Osipenko , baolu.lu@linux.intel.com, Marek Szyprowski Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2023/8/3 8:07, Jason Gunthorpe wrote: > What exynos calls exynos_iommu_detach_device is actually putting the iommu > into identity mode. > > Move to the new core support for ARM_DMA_USE_IOMMU by defining > ops->identity_domain. > > Tested-by: Marek Szyprowski > Acked-by: Marek Szyprowski > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/exynos-iommu.c | 66 +++++++++++++++++------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c275fe71c4db32..5e12b85dfe8705 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -24,6 +24,7 @@ > > typedef u32 sysmmu_iova_t; > typedef u32 sysmmu_pte_t; > +static struct iommu_domain exynos_identity_domain; Is there a conflict between above and below? [...] > > +static struct iommu_domain_ops exynos_identity_ops = { > + .attach_dev = exynos_iommu_identity_attach, > +}; > + > +static struct iommu_domain exynos_identity_domain = { here. Both define the same. > + .type = IOMMU_DOMAIN_IDENTITY, > + .ops = &exynos_identity_ops, > +}; Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1795C001B0 for ; Mon, 14 Aug 2023 04:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:Cc: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KjQs8VB+V9nuGhCn/N7V1ahwE+eouE+3tm5IlYWooAc=; b=xoGRO3AOQ2scjP sJhV56UoZXvZ5gDrGkpwW/4kxHTkYfx9QneLy189LzEgklMfzKm0m9eC6DE56P1v/MUXyqb1QYUCo hBipDEOKg8jAXLEiVTT7h+3leQg2A4Q/k6HWRmoru+fGGuPXVuUDkzDkZYoaxnR2+hHEqgjB3E7gu 2GuO/wSOv3xe0B0OgGKjXoS/Kjb4sOBsE5f5d22NG3kBHve4931PJCxgngyw/gN5fS0ZFrnFxdgse ng7lhfe0Zy3bdFz3PqDwKAuQO/hAxEAiUmx4IecTUdaUhhe17vRSpgHhMm6W7eGxMAOQKWkzbxvAN B7uYc/t8njtC/R0yTYqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVPZU-00G9TJ-2q; Mon, 14 Aug 2023 04:52:52 +0000 Received: from mgamail.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVPZS-00G9SA-1O; Mon, 14 Aug 2023 04:52:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691988770; x=1723524770; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=Qg68hDQyVU5rdKRTZEFIz/aR7ze3OEvBkBX64vYD6UM=; b=cw/2FXNFpAuLJbDqonehrR9olyKM+w6ngfRG3HLUudzgkzg73c9pfGBB yN+tD68O094jZviCDLSP7z7o/Gm+aVW+TZ2qSSvDfk7wseTBTGUTSS8QR Bz6f1iZAYZa65T/McRfcGJU6AdWfLGLDfSUzUV5+/QubtyLLNLltMnNoF FfpIv4Ik3A9rgFvWgvuxLZCCYgBTfJ0kGYsNbf8cu0eJb1yxdM91nh1HE cX0PETGA/atI1ZjDw6oXvDn0ynEBrqUXL02hlppDtIsx4lODrK3uz25Bb TbAknxNSbREcocHf4qaI+4U3xGm6u+7FilucowpXx48t/DqBCU6BxNYX7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="356924289" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="356924289" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="907098556" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="907098556" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 21:52:37 -0700 Message-ID: <0104371e-a824-8ace-eae3-da90df285c41@linux.intel.com> Date: Mon, 14 Aug 2023 12:52:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 10/25] iommu/exynos: Implement an IDENTITY domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <10-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230813_215250_511657_D6E11338 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/8/3 8:07, Jason Gunthorpe wrote: > What exynos calls exynos_iommu_detach_device is actually putting the iommu > into identity mode. > > Move to the new core support for ARM_DMA_USE_IOMMU by defining > ops->identity_domain. > > Tested-by: Marek Szyprowski > Acked-by: Marek Szyprowski > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/exynos-iommu.c | 66 +++++++++++++++++------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index c275fe71c4db32..5e12b85dfe8705 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -24,6 +24,7 @@ > > typedef u32 sysmmu_iova_t; > typedef u32 sysmmu_pte_t; > +static struct iommu_domain exynos_identity_domain; Is there a conflict between above and below? [...] > > +static struct iommu_domain_ops exynos_identity_ops = { > + .attach_dev = exynos_iommu_identity_attach, > +}; > + > +static struct iommu_domain exynos_identity_domain = { here. Both define the same. > + .type = IOMMU_DOMAIN_IDENTITY, > + .ops = &exynos_identity_ops, > +}; Best regards, baolu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel