From: Daniel Phillips <phillips@bonn-fries.net>
To: Ingo Molnar <mingo@elte.hu>, Nico Schottelius <nicos@pcsystems.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5
Date: Wed, 30 May 2001 23:32:21 +0200 [thread overview]
Message-ID: <0105302332211G.06233@starship> (raw)
In-Reply-To: <Pine.LNX.4.33.0105301724570.2384-100000@localhost.localdomain>
In-Reply-To: <Pine.LNX.4.33.0105301724570.2384-100000@localhost.localdomain>
On Wednesday 30 May 2001 17:25, Ingo Molnar wrote:
> On Wed, 30 May 2001, Nico Schottelius wrote:
> > > the default value is 0, that is good enough.
> >
> > hmm.. I don't think so... value of 1 would be much better, because
> > 0 normally disables the speaker.
>
> i confused the value. Yes, an initialization to 1 would be the
> correct, ie.:
>
> +++ linux-2.4.5-nc/kernel/sysctl.c Wed May 9 23:44:30 2001
> @@ -48,6 +49,7 @@
> extern int nr_queued_signals, max_queued_signals;
> extern int sysrq_enabled;
>
> +int pcspeaker_enabled = 1;
I'd go and change the whole patch so that speaker_disabled = 0 is the
default, but that's just me.
--
Daniel
next prev parent reply other threads:[~2001-05-30 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 14:00 [ PATCH ]: disable pcspeaker kernel: 2.4.2 - 2.4.5 Ingo Molnar
2001-05-30 14:27 ` Nico Schottelius
2001-05-30 15:25 ` Ingo Molnar
2001-05-30 21:32 ` Daniel Phillips [this message]
2001-05-31 12:55 ` Nico Schottelius
-- strict thread matches above, loose matches on Subject: below --
2001-05-30 12:10 Nico Schottelius
2001-05-30 12:21 ` Ingo Molnar
2001-05-30 12:52 ` Nico Schottelius
2001-05-30 13:50 ` Masoud Sharbiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0105302332211G.06233@starship \
--to=phillips@bonn-fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nicos@pcsystems.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.