From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Fedin <p.fedin@samsung.com>
Subject: Re: [PATCH v2 2/5] drivers/net/pcap: add public api
	to	create pcap device
Date: Wed, 17 Feb 2016 12:03:36 +0300
Message-ID: <010601d16962$167d31b0$43779510$@samsung.com>
References: <1455289045-25915-1-git-send-email-reshma.pattan@intel.com>
 <1455289045-25915-3-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: 'Reshma Pattan' <reshma.pattan@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com
 [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 09C80C314
 for <dev@dpdk.org>; Wed, 17 Feb 2016 10:03:40 +0100 (CET)
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
 by mailout4.w1.samsung.com
 (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014))
 with ESMTP id <0O2O00GWNP62JI40@mailout4.w1.samsung.com> for dev@dpdk.org;
 Wed, 17 Feb 2016 09:03:38 +0000 (GMT)
In-reply-to: <1455289045-25915-3-git-send-email-reshma.pattan@intel.com>
Content-language: ru
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

 Hello!

> diff --git a/drivers/net/pcap/rte_pmd_pcap_version.map
> b/drivers/net/pcap/rte_pmd_pcap_version.map
> index ef35398..104dc4d 100644
> --- a/drivers/net/pcap/rte_pmd_pcap_version.map
> +++ b/drivers/net/pcap/rte_pmd_pcap_version.map
> @@ -2,3 +2,11 @@ DPDK_2.0 {
> 
>  	local: *;
>  };
> +
> +DPDK_2.3 {
> +	global:
> +
> +	rte_eth_from_pcapsndumpers;
> +
> +} DPDK_2.0;
> +

 This one produces style warning upon git am:
--- cut ---
Applying: drivers/net/pcap: add public api to create pcap
/home/p.fedin/dpdk/.git/rebase-apply/patch:333: new blank line at EOF.
+
--- cut ---

 I guess the last empty line is not needed

Kind regards,
Pavel Fedin
Senior Engineer
Samsung Electronics Research center Russia