Re: [PATCH 1/5] x86/guest: rename a local variable

[Nicola Vetrini <nicola.vetrini@bugseng.com>]

On 2026-05-13 13:44, Jan Beulich wrote:
> ... shadowing a file scope one, thuis violating Misra C:2012 rule 5.3
> ("An identifier declared in an inner scope shall not hide an identifier
> declared in an outer scope"). No difference in generated code.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 

Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

> --- a/xen/arch/x86/guest/xen/xen.c
> +++ b/xen/arch/x86/guest/xen/xen.c
> @@ -203,11 +203,11 @@ static void __init init_memmap(void)
> 
>  static void cf_check xen_evtchn_upcall(void)
>  {
> -    struct vcpu_info *vcpu_info = this_cpu(vcpu_info);
> +    struct vcpu_info *vi = this_cpu(vcpu_info);
>      unsigned long pending;
> 
> -    vcpu_info->evtchn_upcall_pending = 0;
> -    pending = xchg(&vcpu_info->evtchn_pending_sel, 0);
> +    vi->evtchn_upcall_pending = 0;
> +    pending = xchg(&vi->evtchn_pending_sel, 0);
> 
>      while ( pending )
>      {

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253