From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4673C2D0E4 for ; Tue, 24 Nov 2020 22:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FD4620715 for ; Tue, 24 Nov 2020 22:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389077AbgKXWMU (ORCPT ); Tue, 24 Nov 2020 17:12:20 -0500 Received: from elephants.elehost.com ([216.66.27.132]:62416 "EHLO elephants.elehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388540AbgKXWMU (ORCPT ); Tue, 24 Nov 2020 17:12:20 -0500 X-Virus-Scanned: amavisd-new at elehost.com Received: from gnash (cpe00fc8d49d843-cm00fc8d49d840.cpe.net.cable.rogers.com [173.33.189.82]) (authenticated bits=0) by elephants.elehost.com (8.15.2/8.15.2) with ESMTPSA id 0AOMCDRC097709 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 24 Nov 2020 17:12:13 -0500 (EST) (envelope-from rsbecker@nexbridge.com) From: "Randall S. Becker" To: "'Junio C Hamano'" , "'Han-Wen Nienhuys via GitGitGadget'" Cc: , "'Han-Wen Nienhuys'" , "'Han-Wen Nienhuys'" References: In-Reply-To: Subject: RE: [PATCH] move sleep_millisec to git-compat-util.h Date: Tue, 24 Nov 2020 17:12:08 -0500 Message-ID: <011801d6c2ae$dcdbaad0$96930070$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEpHIVxAVOitwfeyhjFK9k+F6/XHgE9K7xpqyk5LOA= Content-Language: en-ca Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On November 24, 2020 4:51 PM, Junio C Hamano wrote: > To: Han-Wen Nienhuys via GitGitGadget > Cc: git@vger.kernel.org; Han-Wen Nienhuys ; Han- > Wen Nienhuys > Subject: Re: [PATCH] move sleep_millisec to git-compat-util.h > > "Han-Wen Nienhuys via GitGitGadget" writes: > > > From: Han-Wen Nienhuys > > > > The sleep function is defined in wrapper.c, so it makes more sense to > > be a in system compatibility header. > > > > Signed-off-by: Han-Wen Nienhuys > > --- > > move sleep_millisec to git-compat-util.h > > Makes sense. I have a platform fix that I'd like to apply once this makes it into the main code. The sleep_millisec uses poll(), which is rather heavy-weight on the NonStop platform. We have a much more efficient sleep function available (with microsecond resolution), which would be more useful unless there is a poll side-effect on which git depends. Would this be acceptable? I could push this at any time really. index bcda41e374..972ecd67bf 100644 --- a/wrapper.c +++ b/wrapper.c @@ -4,6 +4,10 @@ #include "cache.h" #include "config.h" +#ifdef __TANDEM +#include /* for PROCESS_DELAY_ */ +#endif + static int memory_limit_check(size_t size, int gentle) { static size_t limit = 0; @@ -650,7 +654,11 @@ void write_file(const char *path, const char *fmt, ...) void sleep_millisec(int millisec) { +#ifdef __TANDEM + PROCESS_DELAY_(millisec * 1000LL); +#else poll(NULL, 0, millisec); +#endif } int xgethostname(char *buf, size_t len) Regards, Randall