All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stéphane Reichert" <sreichert@sepro-group.com>
To: Edouard Tisserant <edouard.tisserant@gmail.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] TR: RTNet - how to setup rt_fec on IMX6Q (Xenomai 3.0.7)
Date: Fri, 24 Aug 2018 09:07:45 +0200 (CEST)	[thread overview]
Message-ID: <011a01d43b79$28463b80$78d2b280$@sepro-group.com> (raw)
In-Reply-To: <CAOgDLiEp0SzdwJ9G5+T_zUSM-CAKMompHqWE3SXwfmbJhx1meg@mail.gmail.com>

Hello Edouard,

Thanks for your mail.

We already applied these changes in our file fec.c, but it didn"t solve our 
issue.

Il will let you know if we find an issue.

Best regards
Stéphane

-----Message d'origine-----
De : Edouard Tisserant [mailto:edouard.tisserant@gmail.com]
Envoyé : jeudi 23 août 2018 23:10
À : Stéphane Reichert
Cc : Xenomai (xenomai@xenomai.org)
Objet : Re: [Xenomai] TR: RTNet - how to setup rt_fec on IMX6Q (Xenomai 
3.0.7)

Hi Stéphane.

Well, sorry for untested patch, and thanks for your help in debugging it !

Looking back in recent changes in rtnet, this problem may be related to this 
commit (changes on 8139too.c are explicit):
https://gitlab.denx.de/Xenomai/xenomai/commit/3e97e64ee27ce01e8488d06c52bc4681729b30b9

Patching fec.c in a similar way may certainly help, since apparently 
signatures are now incompatible.

Please let me know if it helps.

Best regards,
Edouard.


Le mer. 22 août 2018 à 10:24, Stéphane Reichert <sreichert@sepro-group.com> 
a écrit :
>
> Hello Edouard,
>
> Thanks again for your patch.
>
> I tried it on my kernel, but unfortunately I am facing the same issue
> (ioctl: Resource temporarily unavailable error message on rtping).
>
> Best regards
> Stéphane
>
> -----Message d'origine-----
> De : Edouard Tisserant [mailto:edouard.tisserant@gmail.com]
> Envoyé : mardi 21 août 2018 23:19
> À : Stéphane Reichert; xenomai@xenomai.org Objet : Re: [Xenomai] TR:
> RTNet - how to setup rt_fec on IMX6Q (Xenomai
> 3.0.7)
>
> Hello Stéphane.
>
> I'm porting EtherLAB to Xenomai3 on Imx6, using RTNet instead of
> EtherLAB provided drivers.
>
> This is still work in progress, but the fec.c patch I have now may help.
> Find it attached.
>
> I built it last time on kernel 4.9.51 and xenomai 3.0.6. This is
> largely untested, your feedback is welcome.
>
> Beware content of DTS for vanilla FEC from kernel 4.x may not be
> compatible anymore with the one expected by FEC from RTnet. You may
> have to patch you DTS accordingly.
>
> Best regards,
>
> Edouard
>
>
>
> On 17/08/2018 13:39, Stéphane Reichert wrote:
> > Hello Philippe,
> >
> > I have noticed in the file fec.c that the function fec_enet_ioctl
> > did not match the prototype of do_ioctl (it looks like "request" and 
> > "arg"
> > parameters are switched). Is it a mistake ?
> >
> > (I tried to switch these parameters but it didn't solved my problem
> > as well).
> >
> > Stephane
> >
> >
> > -----Message d'origine-----
> > De : Philippe Gerum [mailto:rpm@xenomai.org] Envoyé : vendredi 17
> > août
> > 2018
> > 10:28 À : Stéphane Reichert; xenomai@xenomai.org Objet : Re:
> > [Xenomai] RTNet - how to setup rt_fec on IMX6Q (Xenomai 3.0.7)
> >
> > On 08/16/2018 03:23 PM, Stéphane Reichert wrote:
> >> Hello,
> >>
> >>
> >>
> >> We are trying to use the rt_fec driver for RTNet on a iMX6Q board.
> >>
> >>
> >>
> >> I have patched the KConfig to add this driver on buildroot and it
> >> compiles perfectly.
> >>
> >>
> >>
> >> But now, I am not able to use it on our board (it works when I “rtping”
> >> the loopback,
> >>
> >> but it doesn’t work if I try to ping an external board).
> > The fec driver does not seem to tell the stack about the carrier
> > enable state. If so, you may want to try the following patch:
> >
> > diff --git a/kernel/drivers/net/drivers/fec.c
> > b/kernel/drivers/net/drivers/fec.c
> > index 36870ba16..d94ec690f 100644
> > --- a/kernel/drivers/net/drivers/fec.c
> > +++ b/kernel/drivers/net/drivers/fec.c
> > @@ -1323,6 +1323,7 @@ fec_enet_open(struct rtnet_device *ndev)
> >               return ret;
> >       }
> >       phy_start(fep->phy_dev);
> > +     rtnetif_carrier_on(ndev);
> >       rtnetif_start_queue(ndev);
> >       fep->opened = 1;
> >       return 0;
> >
> > --
> > Philippe.
> >
> > _______________________________________________
> > Xenomai mailing list
> > Xenomai@xenomai.org
> > https://xenomai.org/mailman/listinfo/xenomai
>


  reply	other threads:[~2018-08-24  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 13:23 [Xenomai] RTNet - how to setup rt_fec on IMX6Q (Xenomai 3.0.7) Stéphane Reichert
2018-08-17  8:27 ` Philippe Gerum
2018-08-17 11:39   ` [Xenomai] TR: " Stéphane Reichert
2018-08-17 11:39   ` Stéphane Reichert
2018-08-21 21:19     ` Edouard Tisserant
2018-08-22  8:24       ` Stéphane Reichert
2018-08-23 21:09         ` Edouard Tisserant
2018-08-24  7:07           ` Stéphane Reichert [this message]
2018-09-10 15:24             ` Edouard Tisserant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011a01d43b79$28463b80$78d2b280$@sepro-group.com' \
    --to=sreichert@sepro-group.com \
    --cc=edouard.tisserant@gmail.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.