All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Gazquez <miguel.gazquez@bootlin.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Phong LE <ple@baylibre.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com,
	kory.maincent@bootlin.com, romain.gantois@bootlin.com,
	praneeth@ti.com, Aradhya Bhatia <a-bhatia1@ti.com>
Subject: Re: [PATCH] drm/bridge: ite-it66121: Add drm_connector support
Date: Thu, 11 Sep 2025 14:49:59 +0200	[thread overview]
Message-ID: <012046ab-d866-4b3a-8c8a-e130bc2b9628@bootlin.com> (raw)
In-Reply-To: <20250911-innocent-daffodil-macaque-797f13@houat>



Le 11/09/2025 à 11:50, Maxime Ripard a écrit :
> On Thu, Sep 11, 2025 at 10:51:06AM +0200, Miguel Gazquez wrote:
>>
>>
>> Le 10/09/2025 à 04:28, Dmitry Baryshkov a écrit :
>>> On Tue, Sep 09, 2025 at 06:16:43PM +0200, Miguel Gazquez wrote:
>>>> From: Aradhya Bhatia <a-bhatia1@ti.com>
>>>>
>>>> Add support for DRM connector and make the driver support the older
>>>> format of attaching connectors onto the encoder->bridge->connector
>>>> chain.
>>>> This makes the driver compatible with display controller that only
>>>> supports the old format.
>>>>
>>>> [Miguel Gazquez: Rebased + made driver work with or without
>>>> DRM_BRIDGE_ATTACH_NO_CONNECTOR]
>>>
>>> What is the use case for not using DRM_BRIDGE_ATTACH_NO_CONNECTOR?
>>
>> Some display controller drivers (like the tilcdc) call drm_bridge_attach
>> without DRM_BRIDGE_ATTACH_NO_CONNECTOR, so the bridge must support both with
>> and without DRM_BRIDGE_ATTACH_NO_CONNECTOR to be compatible with all display
>> controllers.
> 
> I'd rather convert tilcdc to use DRM_BRIDGE_ATTACH_NO_CONNECTOR then.

The problem is that doing that break devicetrees using the tilcdc and a 
bridge who doesn't support DRM_BRIDGE_ATTACH_NO_CONNECTOR (there are 
multiple bridges that don't support DRM_BRIDGE_ATTACH_NO_CONNECTOR), and 
if my understanding is correct breaking devicetrees is not allowed.

> 
> Maxime

-- 
Miguel Gazquez, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2025-09-11 12:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 16:16 [PATCH] drm/bridge: ite-it66121: Add drm_connector support Miguel Gazquez
2025-09-10  2:28 ` Dmitry Baryshkov
2025-09-11  8:51   ` Miguel Gazquez
2025-09-11  9:50     ` Maxime Ripard
2025-09-11 12:49       ` Miguel Gazquez [this message]
2025-09-11 13:09         ` Dmitry Baryshkov
2025-09-11 15:40           ` Miguel Gazquez
2025-09-11 15:47             ` Miguel Gazquez
2025-09-12 10:28               ` Maxime Ripard
2025-09-12 11:20               ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=012046ab-d866-4b3a-8c8a-e130bc2b9628@bootlin.com \
    --to=miguel.gazquez@bootlin.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a-bhatia1@ti.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kory.maincent@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=ple@baylibre.com \
    --cc=praneeth@ti.com \
    --cc=rfoss@kernel.org \
    --cc=romain.gantois@bootlin.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.