From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH 6/6] IB/core: remove ib_get_dma_mr
Date: Mon, 29 Aug 2016 10:32:02 -0500 [thread overview]
Message-ID: <013401d2020a$7d3e7760$77bb6620$@opengridcomputing.com> (raw)
In-Reply-To: <1472464943-29450-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
>
> We now only use it from ib_alloc_pd to create a local DMA lkey if the
> device doesn't provide one, or a global rkey if the ULP requests it.
>
> This patch removes ib_get_dma_mr and open codes the functionality in
> ib_alloc_pd so that we can simply the code and prevent abuse of the
nit: simply -> simplify
> functionality. As a side effect we can also simplify things by removing
> the valid access bit check, and the PD refcounting.
>
> In the future I hope to also remove the per-PD global MR entirely by
> shifting this work into the HW drivers, as one step towards avoiding
> the struct ib_mr overload for various different use cases.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-29 15:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 10:02 move unsafe global rkey handling to the RDMA core Christoph Hellwig
[not found] ` <1472464943-29450-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 10:02 ` [PATCH 1/6] IB/core: rename pd->local_mr to pd->__internal_mr Christoph Hellwig
[not found] ` <1472464943-29450-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:26 ` Steve Wise
2016-08-29 15:32 ` Steve Wise
2016-08-30 15:32 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 2/6] IB/core: add support to create a unsafe global rkey to ib_create_pd Christoph Hellwig
[not found] ` <1472464943-29450-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:27 ` Steve Wise
2016-08-29 15:32 ` Steve Wise
2016-08-30 15:32 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 3/6] IB/iser: use IB_PD_UNSAFE_GLOBAL_RKEY Christoph Hellwig
[not found] ` <1472464943-29450-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:28 ` Steve Wise
2016-08-30 15:33 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 4/6] IB/srp: " Christoph Hellwig
[not found] ` <1472464943-29450-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:29 ` Steve Wise
2016-08-29 17:00 ` Bart Van Assche
[not found] ` <df613e79-7c01-5fa6-5586-6f567254224b-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-08-30 12:47 ` Christoph Hellwig
[not found] ` <20160830124705.GA7585-jcswGhMUV9g@public.gmane.org>
2016-08-30 15:35 ` Sagi Grimberg
2016-08-31 9:32 ` Max Gurtovoy
[not found] ` <bb2a15be-8a22-d889-5eb6-c0f315465507-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-05 10:24 ` Christoph Hellwig
2016-08-29 10:02 ` [PATCH 5/6] nvme-rdma: " Christoph Hellwig
[not found] ` <1472464943-29450-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:30 ` Steve Wise
2016-08-30 15:35 ` Sagi Grimberg
[not found] ` <148fd046-c239-a416-8409-202661e19876-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-09-05 10:34 ` Christoph Hellwig
2016-08-29 10:02 ` [PATCH 6/6] IB/core: remove ib_get_dma_mr Christoph Hellwig
[not found] ` <1472464943-29450-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:32 ` Steve Wise [this message]
2016-08-30 15:36 ` Sagi Grimberg
2016-08-29 16:42 ` move unsafe global rkey handling to the RDMA core Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2016-09-05 10:56 move unsafe global rkey handling to the RDMA core V2 Christoph Hellwig
[not found] ` <1473072981-2035-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-05 10:56 ` [PATCH 6/6] IB/core: remove ib_get_dma_mr Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013401d2020a$7d3e7760$77bb6620$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.