All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel
Date: Mon, 23 Jul 2007 00:49:53 +0200	[thread overview]
Message-ID: <013701c7ccb3$1a92a960$dcc4af0a@atmel.com> (raw)
In-Reply-To: 46A3B766.2000808@realitydiluted.com


> ulf at uclibc.org wrote:
>> Author: ulf
>> Date: 2007-07-22 10:17:03 -0700 (Sun, 22 Jul 2007)
>> New Revision: 19194
>> 
>> Log:
>> ATMEL_MIRROR needs to be available before toolchain is built
>> 
>> Modified:
>>    trunk/buildroot/package/Makefile.in
>>    trunk/buildroot/target/device/Atmel/Makefile.in
>> 
> Ulf,
> 
> Please do not put any platform dependent code in the 'package/Makefile.in'
> file. It does not belong there. I will revert your change.
> 


While it is used for target/device/Atmel files, it is also needed
to download binutils/gcc/gdb tarballs for AVR32 architecture support.
If it is defined in target/device/Atmel, then it is not defined during
the toolchain build. causing this to fail.

The alternative is to submit a 7-10 MB patch+ for the buildroot tree
with all the AVR32 architecture patches, which I thought was a bad idea.

If you don't like that location, you need to come up with a location
where to put the definition of ATMEL_MIRROR *before*
"include toolchain/*/*.mk" in the main Makefile

The main Makefile seems to be the only other suitable location.


Best Regards
Ulf Samuelsson

  reply	other threads:[~2007-07-22 22:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22 17:17 [Buildroot] svn commit: trunk/buildroot: package target/device/Atmel ulf at uclibc.org
2007-07-22 20:00 ` Steven J. Hill
2007-07-22 22:49   ` Ulf Samuelsson [this message]
2007-07-23  2:55     ` [Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel Steven J. Hill
2007-07-23  6:25       ` Ulf Samuelsson
     [not found]     ` <1185428949.31437.4.camel@localhost.localdomain>
2007-07-26  6:03       ` [Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel Ulf Samuelsson
2007-07-26  7:30         ` Hans-Christian Egtvedt
     [not found]         ` <1185434977.31437.50.camel@localhost.localdomain>
2007-07-26 16:55           ` Ulf Samuelsson
2007-07-27  6:07             ` Hans-Christian Egtvedt
2007-07-27  8:48               ` Ulf Samuelsson
2007-07-27 14:11               ` Hans-Christian Egtvedt
2007-07-26  7:01     ` [Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel Hans-Christian Egtvedt
  -- strict thread matches above, loose matches on Subject: below --
2007-07-23  9:40 Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='013701c7ccb3$1a92a960$dcc4af0a@atmel.com' \
    --to=ulf@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.