From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwuHL-00033S-1N for qemu-devel@nongnu.org; Mon, 25 May 2015 11:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwuHG-0001Xh-V0 for qemu-devel@nongnu.org; Mon, 25 May 2015 11:26:58 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:45405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwuHG-0001Tc-On for qemu-devel@nongnu.org; Mon, 25 May 2015 11:26:54 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NOW00AHQW8OZ080@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 25 May 2015 16:26:48 +0100 (BST) From: Pavel Fedin References: <1430921082-16779-1-git-send-email-shlomopongratz@gmail.com> <1430921082-16779-3-git-send-email-shlomopongratz@gmail.com> <555F28BD.8080001@linaro.org> In-reply-to: <555F28BD.8080001@linaro.org> Date: Mon, 25 May 2015 18:26:42 +0300 Message-id: <013801d096ff$373bfed0$a5b3fc70$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ru Subject: Re: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Eric Auger' , qemu-devel@nongnu.org, shlomopongratz@gmail.com, 'Shlomo Pongratz' Hi! > > +static const uint8_t gic_lpi_ids[] = { > > + 0x44, 0x00, 0x00, 0x00, 0x093, 0xB4, 0x3B, 0x00, 0x0D, 0xF0, 0x05, 0xB1 > > +}; Found one more thing. Shouldn't there be 0x091 instead of 0x093 (5th byte = PIDR0) ? 0x93 is ITS while REDIST is 0x91. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia