All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH] drm/i915: gracefully bail out when init_clock_gating-pointer is not set
Date: Mon, 20 Jun 2011 17:43:22 +0100	[thread overview]
Message-ID: <013811$hje8d@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1308586230-22484-1-git-send-email-w.sang@pengutronix.de>

On Mon, 20 Jun 2011 18:10:30 +0200, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Commit 6067aa (drm/i915: split clock gating init into per-chipset
> functions) introduces an init_clock_gating-pointer. There is one case,
> however, where it does not get set, so that caused an OOPS (Bug 37252).
> Change the code to return -ENODEV in this case and propagate it to the
> upper layers.

That's better, the system will continue to boot now and we will have an
appropriate error message.

> -		} else
> -			dev_priv->display.update_wm = NULL;
> +		} else {
> +			dev_err(dev->dev, "Unknown type!\n");
DRM_ERROR("Unknown chipset: %lx\n", dev->pci_device);
> +			return -ENODEV;
> +		}

DRM_ERROR to be in keeping with the rest of the code, and a bit of context
in case the error is ever pasted into bugzilla.kernel.org.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-06-20 16:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 22:24 [PATCH] drm/i915: add check for valid init_clock_gating-pointer Wolfram Sang
2011-06-15 22:30 ` Jesse Barnes
2011-06-16 13:28   ` Wolfram Sang
2011-06-16 15:15     ` Jesse Barnes
2011-06-16 15:47       ` Chris Wilson
2011-06-19 19:22         ` Wolfram Sang
2011-06-19 20:04           ` Chris Wilson
2011-06-20 16:10             ` [PATCH] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Wolfram Sang
2011-06-20 16:43               ` Chris Wilson [this message]
2011-06-20 17:36                 ` [PATCH V2] " Wolfram Sang
2011-06-20 17:38                   ` Jesse Barnes
2011-07-02 15:55                     ` Wolfram Sang
2011-07-02 18:00                       ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='013811$hje8d@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.