From: <ansuelsmth@gmail.com>
To: "'Stephen Boyd'" <sboyd@kernel.org>, <agross@kernel.org>
Cc: "'Mathieu Olivari'" <mathieu@codeaurora.org>,
"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Mark Rutland'" <mark.rutland@arm.com>,
"'Michael Turquette'" <mturquette@baylibre.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: R: [PATCH] ARM: qcom: Disable i2c device on gsbi4 for ipq806x
Date: Fri, 13 Mar 2020 23:34:05 +0100 [thread overview]
Message-ID: <014101d5f987$82790c90$876b25b0$@gmail.com> (raw)
In-Reply-To: <158413179776.164562.8295974225127853050@swboyd.mtv.corp.google.com>
> Quoting Ansuel Smith (2020-03-13 12:58:16)
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > index 554c65e7aa0e..580aec63030d 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > +++ b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > @@ -21,14 +21,5 @@ mux {
> > };
> > };
> > };
> > -
> > - gsbi@16300000 {
> > - i2c@16380000 {
> > - status = "ok";
> > - clock-frequency = <200000>;
> > - pinctrl-0 = <&i2c4_pins>;
> > - pinctrl-names = "default";
> > - };
> > - };
> > };
> > };
> > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-
> ipq806x.c
> > index b0eee0903807..75706807e6cf 100644
> > --- a/drivers/clk/qcom/gcc-ipq806x.c
> > +++ b/drivers/clk/qcom/gcc-ipq806x.c
> > @@ -782,7 +782,7 @@ static struct clk_rcg gsbi4_qup_src = {
> > .parent_names = gcc_pxo_pll8,
> > .num_parents = 2,
> > .ops = &clk_rcg_ops,
> > - .flags = CLK_SET_PARENT_GATE,
> > + .flags = CLK_SET_PARENT_GATE | CLK_IGNORE_UNUSED,
>
> A better solution is to use the protected-clocks property so we don't
> try to touch these clks at all on this device. So this whole patch can
> be routed through arm-soc and remove the i2c node and add some dt
> property to the gcc node.
>
Should I add a comment where the i2c is removed or I can remove it
directly?
> > },
> > },
> > };
next prev parent reply other threads:[~2020-03-13 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 19:58 [PATCH] ARM: qcom: Disable i2c device on gsbi4 for ipq806x Ansuel Smith
2020-03-13 20:36 ` Stephen Boyd
2020-03-13 22:34 ` ansuelsmth [this message]
2020-03-13 23:46 ` R: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014101d5f987$82790c90$876b25b0$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu@codeaurora.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.