From: Heiner Kallweit <hkallweit1@gmail.com>
To: ChunHao Lin <hau@realtek.com>,
nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] r8169: set EEE speed down ratio to 1
Date: Thu, 18 Sep 2025 07:43:45 +0200 [thread overview]
Message-ID: <014711f8-2d63-4ba7-9c95-89b171476172@gmail.com> (raw)
In-Reply-To: <20250918023425.3463-1-hau@realtek.com>
On 9/18/2025 4:34 AM, ChunHao Lin wrote:
> EEE speed down means speed down MAC MCU clock. It is not from spec.
> It is kind of Realtek specific power saving feature. But enable it
> may cause some issues, like packet drop or interrupt loss. Different
> hardware may have different issues.
>
> EEE speed down ratio (mac ocp 0xe056[7:4]) is used to set EEE speed
> down rate. The larger this value is, the more power can save. But it
> actually save less power then we expected. And, as mentioned above,
> will impact compatibility. So set it to 1 (mac ocp 0xe056[7:4] = 0)
> , which means not to speed down, to improve compatibility.
>
> Signed-off-by: ChunHao Lin <hau@realtek.com>
> ---
> v1 -> v2: update commit message
>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2025-09-18 5:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 2:34 [PATCH net-next v2] r8169: set EEE speed down ratio to 1 ChunHao Lin
2025-09-18 5:43 ` Heiner Kallweit [this message]
2025-09-19 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=014711f8-2d63-4ba7-9c95-89b171476172@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hau@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.