From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4AE12EA74A for ; Tue, 26 Aug 2025 17:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.209.179.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756230806; cv=none; b=MOebwcObnnZZlYlNMYmsPtde4OMa2/6O+WYHaWqIFX+ZdzNR+cJD4Ul+McQ5BAFVRvMv+ctW6BuZ8Yp1H5OHxQVm0kbAsySinsTkHmA6ojU8zL85Ug+rizkb5PopowDoNORJrXk6e3ygsqJfZGNhLr2W7IxgkJaVhWMCjQ5JT+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756230806; c=relaxed/simple; bh=SM9hndYWG0atyuDkOcImQ75fIHLwR/LfE/qln8723B8=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=lctr6yzPlfG7wb5zWf2saZUOaHPmw3yaFQ5GBIu9NlYNrRPmTBUXRCGYEmZStL+BJSXALD8i9zS4PIDBU2npgG7MmLyyaOblublgxZwkLjhUfKxMjtUCdtqbEBJXVl6kzUBZCjFkMCqb11XAB5MUK04nAVa4TJMF7no8dklL2Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com; spf=pass smtp.mailfrom=nexbridge.com; arc=none smtp.client-ip=185.209.179.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexbridge.com X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen (pool-99-228-67-183.cpe.net.cable.rogers.com [99.228.67.183]) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 57QHrAZf4052923 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Aug 2025 17:53:10 GMT Reply-To: From: To: "'Kyle Lippincott'" , "'David Aguilar'" Cc: "'Junio C Hamano'" , , "'Ezekiel Newren'" , "'Josh Steadmon'" , "'Calvin Wan'" References: <20250826160437.2539113-1-davvid@gmail.com> In-Reply-To: Subject: RE: [PATCH] Makefile: build libgit-rs and libgit-sys serially Date: Tue, 26 Aug 2025 13:53:05 -0400 Organization: Nexbridge Inc. Message-ID: <014b01dc16b2$4a1dd0d0$de597270$@nexbridge.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-ca Thread-Index: AQFwjz3pQA+GbovpDjmi3ET08E4BLgKAL7GitThEQXA= X-Antivirus: Norton (VPS 250826-4, 8/26/2025), Outbound message X-Antivirus-Status: Clean On August 26, 2025 1:45 PM, Kyle Lippincott wrote: >On Tue, Aug 26, 2025 at 9:04=E2=80=AFAM David Aguilar = wrote: >> >> The "cargo build" invocations in contrib/ cannot be run in parallel. >> >> "make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings >> and can trigger ld errors during the build. >> >> The build errors are caused by two inner "make" invocations getting >> triggered concurrently: once inside of libgit-sys and another inside >> of libgit-rs. >> >> Signed-off-by: David Aguilar >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index 29a53520fd..286d3ba3b2 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -3989,7 +3989,7 @@ libgit-sys libgit-rs: >> cargo build \ >> ) >> ifdef INCLUDE_LIBGIT_RS >> -all:: libgit-sys libgit-rs >> +all:: libgit-sys .WAIT libgit-rs > >I'm not familiar enough with make or with rust, but do we need to = depend on both >of these here? Wouldn't it be sufficient to say libgit-rs depends on = libgit-sys, and >only explicitly depend on libgit-rs in `all::`? Not all platforms can build libgit-rs, so inserting it into as a = required component is not a particularly friendly idea.