From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Fedin Subject: RE: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi Date: Tue, 07 Jul 2015 10:23:29 +0300 Message-ID: <014d01d0b885$d3228380$79678a80$@samsung.com> References: <1435592237-17924-1-git-send-email-eric.auger@linaro.org> <1435592237-17924-2-git-send-email-eric.auger@linaro.org> <011f01d0b498$6a17aeb0$3e470c10$@samsung.com> <5596503E.6040902@arm.com> <00fd01d0b7b6$f6cf3550$e46d9ff0$@samsung.com> <559A3C9C.6050302@arm.com> <20150706093026.GA11590@cbox> <559A52E6.5050402@arm.com> <20150706103755.GC11590@cbox> <559A6164.1000401@redhat.com> <559A6527.1040107@arm.com> <559A6BBC.2040901@redhat.com> <024301d0b7f0$2b13b410$813b1c30$@samsung.com> <559A9854.2090607@linaro.org> <559AA449.80705@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E288457D69 for ; Tue, 7 Jul 2015 03:12:05 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6uZn189g-Bys for ; Tue, 7 Jul 2015 03:12:04 -0400 (EDT) Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0D2AB57D66 for ; Tue, 7 Jul 2015 03:12:03 -0400 (EDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NR300JBOWJ6B330@mailout4.w1.samsung.com> for kvmarm@lists.cs.columbia.edu; Tue, 07 Jul 2015 08:23:30 +0100 (BST) In-reply-to: <559AA449.80705@arm.com> Content-language: ru List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: 'Andre Przywara' , 'Eric Auger' , 'Paolo Bonzini' , 'Christoffer Dall' Cc: eric.auger@st.com, kvm@vger.kernel.org, 'Marc Zyngier' , linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu Hi! > I guess not. But I prefer the new type anyway, as it also has a known > error path for older kernels. flags != 0 has known error path too, and it's absolutely the same. Sorry, read this after writing my previous reply, so this is a short addendum. I see lots of people agreed on a new type. If my argument about reusing existing definitions is not enough, you can ignore it. Three people beat one definitely. :) And yes, since we are talking about it, actually KVM_MSI_VALID_DEVID flag is not yet a part of mainline, so it's not set in stone. Then, perhaps you could throw it away completely and invent KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be consistent IMO. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.fedin@samsung.com (Pavel Fedin) Date: Tue, 07 Jul 2015 10:23:29 +0300 Subject: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi In-Reply-To: <559AA449.80705@arm.com> References: <1435592237-17924-1-git-send-email-eric.auger@linaro.org> <1435592237-17924-2-git-send-email-eric.auger@linaro.org> <011f01d0b498$6a17aeb0$3e470c10$@samsung.com> <5596503E.6040902@arm.com> <00fd01d0b7b6$f6cf3550$e46d9ff0$@samsung.com> <559A3C9C.6050302@arm.com> <20150706093026.GA11590@cbox> <559A52E6.5050402@arm.com> <20150706103755.GC11590@cbox> <559A6164.1000401@redhat.com> <559A6527.1040107@arm.com> <559A6BBC.2040901@redhat.com> <024301d0b7f0$2b13b410$813b1c30$@samsung.com> <559A9854.2090607@linaro.org> <559AA449.80705@arm.com> Message-ID: <014d01d0b885$d3228380$79678a80$@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi! > I guess not. But I prefer the new type anyway, as it also has a known > error path for older kernels. flags != 0 has known error path too, and it's absolutely the same. Sorry, read this after writing my previous reply, so this is a short addendum. I see lots of people agreed on a new type. If my argument about reusing existing definitions is not enough, you can ignore it. Three people beat one definitely. :) And yes, since we are talking about it, actually KVM_MSI_VALID_DEVID flag is not yet a part of mainline, so it's not set in stone. Then, perhaps you could throw it away completely and invent KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be consistent IMO. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140AbbGGHXf (ORCPT ); Tue, 7 Jul 2015 03:23:35 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:45270 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbbGGHXd (ORCPT ); Tue, 7 Jul 2015 03:23:33 -0400 X-AuditID: cbfec7f5-f794b6d000001495-c8-559b7e72b11c From: Pavel Fedin To: "'Andre Przywara'" , "'Eric Auger'" , "'Paolo Bonzini'" , "'Christoffer Dall'" Cc: eric.auger@st.com, linux-arm-kernel@lists.infradead.org, "'Marc Zyngier'" , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1435592237-17924-1-git-send-email-eric.auger@linaro.org> <1435592237-17924-2-git-send-email-eric.auger@linaro.org> <011f01d0b498$6a17aeb0$3e470c10$@samsung.com> <5596503E.6040902@arm.com> <00fd01d0b7b6$f6cf3550$e46d9ff0$@samsung.com> <559A3C9C.6050302@arm.com> <20150706093026.GA11590@cbox> <559A52E6.5050402@arm.com> <20150706103755.GC11590@cbox> <559A6164.1000401@redhat.com> <559A6527.1040107@arm.com> <559A6BBC.2040901@redhat.com> <024301d0b7f0$2b13b410$813b1c30$@samsung.com> <559A9854.2090607@linaro.org> <559AA449.80705@arm.com> In-reply-to: <559AA449.80705@arm.com> Subject: RE: [PATCH 1/7] KVM: api: add kvm_irq_routing_extended_msi Date: Tue, 07 Jul 2015 10:23:29 +0300 Message-id: <014d01d0b885$d3228380$79678a80$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQIj+X5s5FdAGWwAOFAf7dE3NOV/zwG0/EgbAfNFYEkCdP68yAI2kmrgAcGjK5UBdOO3AQInn0A7AhPZAhABkKKCDwD4t3eDAoJbRakDRTGpLgL2uZX3AfUqNYCcQQJqgA== Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t/xK7pFdbNDDc6+1rNYMe8no8WL1/8Y LeZvOcNqcXXzWSaLOVMLLT6eOs5usenxNVaLy7vmsFn8vfOPzWL/tn+sDlwea+atYfS4c20P m8f5TWuYPTYvqfd4v+8qm8fTH3uZPT5vkgtgj+KySUnNySxLLdK3S+DK+DT5AmvBRraK/4dX sTQwtrN2MXJySAiYSPyau5QRwhaTuHBvPVsXIxeHkMBSRokd244wQjjfGSVerOlhBqliE1CX OP31AwtIQkRgA6PErNaDYA6zwHZGiXt/jzJDtGxhkTi2/AxYC6eAqsTUMxdZQGxhAWeJVf8P gMVZgOK3X90As3kFLCW6px6EsgUlfky+B1bPLKAlsX7ncSYIW15i85q3zBDHKkjsOPuaEeKM KUD3tU9jhSgSkZj27x7zBEahWUhmzUIyaxaSWbOQtCxgZFnFKJpamlxQnJSea6RXnJhbXJqX rpecn7uJERJlX3cwLj1mdYhRgINRiYf3hsTsUCHWxLLiytxDjBIczEoivLqlQCHelMTKqtSi /Pii0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwro3Y9Xly7xPh8Jcz3f7b fvZaUp/V1Lns1qPfKRtZTy3dEHgzZvsyzgVFE70vzma/vtkgbbVR67GlBy5UJW3kfmxXfrjn 6sJDesUrVUQqRZSZC6JyGnZFvns06at5ActKocRjl/vi1vl3tm/qSKp8yvZBPo2d0+xW7SbO hdYza6d/vzHhPttUeSWW4oxEQy3mouJEAPhtk7WuAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > I guess not. But I prefer the new type anyway, as it also has a known > error path for older kernels. flags != 0 has known error path too, and it's absolutely the same. Sorry, read this after writing my previous reply, so this is a short addendum. I see lots of people agreed on a new type. If my argument about reusing existing definitions is not enough, you can ignore it. Three people beat one definitely. :) And yes, since we are talking about it, actually KVM_MSI_VALID_DEVID flag is not yet a part of mainline, so it's not set in stone. Then, perhaps you could throw it away completely and invent KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be consistent IMO. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia