From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9B520330 for ; Thu, 5 Jun 2025 21:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.209.179.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749159899; cv=none; b=twm0KIzljWrQyIOj4S/yq8j2X1Fj//VaXHLWhuRRDPviGZutn3WeVBTZ9op3O7qCzFgQ/dE94jhCC93Oeln3TX6wA6QP+tNGKZ0KNt+wnu4xPdWz+eUwjfOJmm1AjqDdTYSmFWPcK31ykpU/Z3DOBePntwq6I8kYrkg9v04q8nY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749159899; c=relaxed/simple; bh=WkA71kmMGOHot2bQj++0kfyfPKDZD1JOySMYCNLw73Y=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=edneiWjwTP7On7iKfb3LNDvj+0+czcoHzrojpst7YZ2ipdLqFGdxkffDo0G+Kj8OhmIa3OD57pvdrNS27TZdl2zdBZ29t/J2mAsuvMe3uf9uDoci4HIERWD9Rfe+77jEvzKAJjIPXLM14oSDtRhHzbrXykzFf5mxoB8RmpKdj80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com; spf=pass smtp.mailfrom=nexbridge.com; arc=none smtp.client-ip=185.209.179.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexbridge.com X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen ([185.122.133.20]) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 555Limei771605 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Jun 2025 21:44:49 GMT Reply-To: From: To: "'Johannes Sixt'" , "'Patrick Steinhardt'" Cc: "'Junio C Hamano'" , , "'Todd Zullinger'" References: <007a01dbd4d7$89ebf100$9dc3d300$@nexbridge.com> <007d01dbd4d9$356ded70$a049c850$@nexbridge.com> <44fe8627-5680-443d-bf02-a6e85afd46b4@kdbg.org> <010b01dbd5f1$3c26ec20$b474c460$@nexbridge.com> <014201dbd658$4da75680$e8f60380$@nexbridge.com> In-Reply-To: Subject: RE: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed Date: Thu, 5 Jun 2025 17:44:41 -0400 Organization: Nexbridge Inc. Message-ID: <014f01dbd663$0ef73530$2ce59f90$@nexbridge.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQE/8OENAHtdeNmfXNuu5L7gSMXaAQGPhlBYAT32OawCDCTCZQHcPefDAfT2uzQCU1eiuwIb33kTAnEuQ6cB9MdkjLSg5BGA Content-Language: en-ca X-Antivirus: Norton (VPS 250605-8, 6/5/2025), Outbound message X-Antivirus-Status: Clean On June 5, 2025 5:12 PM, Johannes Sixt wrote: >Am 05.06.25 um 22:27 schrieb rsbecker@nexbridge.com: >> The *.tcl files in git-gui/lib are gone after the above command. I >> noticed a few things run by the above - this did not happen in 2.49. >> >> /usr/coreutils/bin/make -C git-gui >> gitexecdir='/usr/local-ssl3.5/libexec/git-core' all >> make[1]: Entering directory >> '/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/git-gui' >> GITGUI_VERSION=0.21.GITGUI >> /usr/coreutils/bin/bash generate-git-gui.sh "git-gui.sh" "git-gui" >> ./GIT-GUI-BUILD-OPTIONS ./GIT-VERSION-FILE /usr/coreutils/bin/bash >> generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS lib/merge.tcl >> lib/error.tcl lib/chord.tcl lib/date.tcl lib/encoding.tcl >... >> generate-tclindex.sh: line 21: tclsh: command not found >> * tclsh failed; using unoptimized loading >> >> It appears the above removes the *.tcl files. That causes the >> subsequent failure. > >Interesting. We have this in generate-tclindex.sh: > >... >else > echo >&2 " * $TCL_PATH failed; using unoptimized loading" > rm -f $@ > echo '# Autogenerated by git-gui Makefile' >lib/tclIndex ... > >This $@ was taken literally from the Makefile, where it means something very >different than in the shell script. The line could be > > rm -f lib/tclIndex > >or it could be deleted because the next line overwrites the file anyway. > >In the meantime, setting NO_TCLTK=NoThanks in config.mak is probably the >quickest fix for you. > >Thank you for the report. Can I pass this in via command line? Instead of modifying config.mak?