All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <rpurdie@rpsys.net>
To: linux-ide@vger.kernel.org
Subject: Re: Problems with ide-cs.c
Date: Wed, 15 Dec 2004 14:51:15 -0000	[thread overview]
Message-ID: <015101c4e2b5$8a1d23e0$0f01a8c0@max> (raw)
In-Reply-To: 046201c4e156$5862e610$0f01a8c0@max

I wrote:
> If the usage count for the device is non-zero ide_unregister will fail
> which is likely if you just pull the card out. This silent failure leads
> to all kinds of problems which break the device until it's rebooted -
> quite a serious bug. There is a fixme in ide-cs.c relating to this.

I've been looking into this. I think the simplest approach is to make sure 
ide_unregister() succeeds regardless of any busy/usage status.

In order to make it succeed, I found I needed to add some checks on various 
functions to see if drives were dead or interface's present. I've made a 
working patch available at http://www.rpsys.net/openzaurus/ide.patch . If 
someone who knows more about the ide system could have a look at this, I'd 
appreciate it. If a patch along these lines could be included, it would 
unbreak ide_unregister() and hence the ide_cs module.

Thanks,

Richard 


      reply	other threads:[~2004-12-15 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-13 20:57 Problems with ide-cs.c Richard Purdie
2004-12-15 14:51 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015101c4e2b5$8a1d23e0$0f01a8c0@max' \
    --to=rpurdie@rpsys.net \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.