All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Ashok Kumar' <ashoks@broadcom.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
	'Eric Auger' <eric.auger@linaro.org>,
	'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
	'Shlomo Pongratz' <shlomopongratz@gmail.com>,
	qemu-devel@nongnu.org,
	'Christoffer Dall' <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v11 5/5] hw/arm/virt: Add gic-version	option to virt machine
Date: Tue, 25 Aug 2015 16:53:15 +0300	[thread overview]
Message-ID: <015101d0df3d$64754330$2d5fc990$@samsung.com> (raw)
In-Reply-To: <"20150825134053.GB27329@ashoks"@broadcom.com>

 Hello!

> In KVM case instead of assigning GICv2 as default, can we probe the KVM
> for GICv3 presence using KVM_CREATE_DEVICE_TEST and give priority to
> GICv3?

 We could, but i think this would hurt usability. I suggest that when the user chooses a
configuration, he/she expects to get something particular. And IMHO it's much better to default to
GICv2 (to be backwards-compatible), and just report error in case if this is not supported by KVM,
than to default to something, which is different on different machines and different kernels.
 Libvirt guys already blame "virt" machine for being too flexible...

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

  parent reply	other threads:[~2015-08-25 13:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19  7:23 [Qemu-devel] [PATCH v11 0/5] vGICv3 support Pavel Fedin
2015-08-19  7:23 ` [Qemu-devel] [PATCH v11 1/5] hw/intc: Implement GIC-500 base class Pavel Fedin
2015-08-19  7:23 ` [Qemu-devel] [PATCH v11 2/5] intc/gic: Extract some reusable vGIC code Pavel Fedin
2015-08-19  7:23 ` [Qemu-devel] [PATCH v11 3/5] arm_kvm: Do not assume particular GIC type in kvm_arch_irqchip_create() Pavel Fedin
2015-08-19  7:23 ` [Qemu-devel] [PATCH v11 4/5] hw/intc: Initial implementation of vGICv3 Pavel Fedin
2015-08-19  7:23 ` [Qemu-devel] [PATCH v11 5/5] hw/arm/virt: Add gic-version option to virt machine Pavel Fedin
2015-08-25 13:40   ` Ashok Kumar
     [not found]   ` <"20150825134053.GB27329@ashoks"@broadcom.com>
2015-08-25 13:53     ` Pavel Fedin [this message]
2015-08-25 13:31 ` [Qemu-devel] [PATCH v11 0/5] vGICv3 support Ashok Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015101d0df3d$64754330$2d5fc990$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=ashoks@broadcom.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shlomo.pongratz@huawei.com \
    --cc=shlomopongratz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.