From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54069)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from
) id 1Zn5U7-00084N-Am
for qemu-devel@nongnu.org; Fri, 16 Oct 2015 09:55:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1Zn5U3-0007en-CW
for qemu-devel@nongnu.org; Fri, 16 Oct 2015 09:55:50 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:34086)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1Zn5U3-0007cs-4h
for qemu-devel@nongnu.org; Fri, 16 Oct 2015 09:55:47 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
by mailout2.w1.samsung.com
(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
2014)) with ESMTP id <0NWB005WLG0WUC20@mailout2.w1.samsung.com> for
qemu-devel@nongnu.org; Fri, 16 Oct 2015 14:55:44 +0100 (BST)
From: Pavel Fedin
References: <015801d10818$95084700$bf18d500$@samsung.com>
In-reply-to:
Date: Fri, 16 Oct 2015 16:55:43 +0300
Message-id: <015901d1081a$5a04c910$0e0e5b30$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration
if not supported
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: 'Peter Maydell'
Cc: 'QEMU Developers'
Hello!
> > + if (kvm_arm_gic_can_save_restore(s)) {
> > + kvm_arm_gic_put(s);
> > + }
>=20
> Why change the reset method in a patch that's dealing with adding
> a warning about migration?
Since pre_save and post_load will never be called if migration is =
disabled, i removed unnecessary checks from there. But, since reset =
method calls post_load, i had to add the check there.
Actually, i would factor away kvm_arm_gic_reset() completely, because =
all it does is calling parent's reset, then calling post_load. This can =
perfectly be done in parent class. For software-emulated GICv3 post_load =
callback is simply not used, so that would be safe.
But, i remember that you don't like just refactoring, so i decided to =
stop at the point which you see. :)
=20
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia