From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>
Cc: <kohada.tetsuhiro@dc.mitsubishielectric.co.jp>,
<mori.takahiro@ab.mitsubishielectric.co.jp>,
<motai.hirotaka@aj.mitsubishielectric.co.jp>,
"'Namjae Jeon'" <namjae.jeon@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] exfat: replace memcpy with structure assignment
Date: Wed, 16 Sep 2020 11:23:11 +0900 [thread overview]
Message-ID: <015e01d68bd0$5324fe00$f96efa00$@samsung.com> (raw)
In-Reply-To: <20200911044519.13981-1-kohada.t2@gmail.com>
> Use structure assignment instead of memcpy.
>
> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com>
Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
> fs/exfat/dir.c | 7 ++-----
> fs/exfat/inode.c | 2 +-
> fs/exfat/namei.c | 15 +++++++--------
> 3 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index
> fa5bb72aa295..8520decd120c 100644
> --- a/fs/exfat/dir.c
> +++ b/fs/exfat/dir.c
> @@ -974,11 +974,8 @@ int exfat_find_dir_entry(struct super_block *sb,
> struct exfat_inode_info *ei,
> if (ei->hint_femp.eidx ==
> EXFAT_HINT_NONE ||
> candi_empty.eidx <=
> - ei->hint_femp.eidx)
{
> - memcpy(&ei->hint_femp,
> - &candi_empty,
> -
sizeof(candi_empty));
> - }
> + ei->hint_femp.eidx)
> + ei->hint_femp = candi_empty;
> }
>
> brelse(bh);
> diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c index
> 70a33d4807c3..687f77653187 100644
> --- a/fs/exfat/inode.c
> +++ b/fs/exfat/inode.c
> @@ -554,7 +554,7 @@ static int exfat_fill_inode(struct inode *inode,
> struct exfat_dir_entry *info)
> struct exfat_inode_info *ei = EXFAT_I(inode);
> loff_t size = info->size;
>
> - memcpy(&ei->dir, &info->dir, sizeof(struct exfat_chain));
> + ei->dir = info->dir;
> ei->entry = info->entry;
> ei->attr = info->attr;
> ei->start_clu = info->start_clu;
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index
> 1c433491f771..2932b23a3b6c 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -318,8 +318,7 @@ static int exfat_find_empty_entry(struct inode *inode,
> hint_femp.eidx = EXFAT_HINT_NONE;
>
> if (ei->hint_femp.eidx != EXFAT_HINT_NONE) {
> - memcpy(&hint_femp, &ei->hint_femp,
> - sizeof(struct exfat_hint_femp));
> + hint_femp = ei->hint_femp;
> ei->hint_femp.eidx = EXFAT_HINT_NONE;
> }
>
> @@ -519,7 +518,7 @@ static int exfat_add_entry(struct inode *inode, const
> char *path,
> if (ret)
> goto out;
>
> - memcpy(&info->dir, p_dir, sizeof(struct exfat_chain));
> + info->dir = *p_dir;
> info->entry = dentry;
> info->flags = ALLOC_NO_FAT_CHAIN;
> info->type = type;
> @@ -625,7 +624,7 @@ static int exfat_find(struct inode *dir, struct qstr
> *qname,
> if (dentry < 0)
> return dentry; /* -error value */
>
> - memcpy(&info->dir, &cdir.dir, sizeof(struct exfat_chain));
> + info->dir = cdir;
> info->entry = dentry;
> info->num_subdirs = 0;
>
> @@ -1030,7 +1029,7 @@ static int exfat_rename_file(struct inode *inode,
> struct exfat_chain *p_dir,
> if (!epnew)
> return -EIO;
>
> - memcpy(epnew, epold, DENTRY_SIZE);
> + *epnew = *epold;
> if (exfat_get_entry_type(epnew) == TYPE_FILE) {
> epnew->dentry.file.attr |=
cpu_to_le16(ATTR_ARCHIVE);
> ei->attr |= ATTR_ARCHIVE;
> @@ -1050,7 +1049,7 @@ static int exfat_rename_file(struct inode *inode,
> struct exfat_chain *p_dir,
> return -EIO;
> }
>
> - memcpy(epnew, epold, DENTRY_SIZE);
> + *epnew = *epold;
> exfat_update_bh(new_bh, sync);
> brelse(old_bh);
> brelse(new_bh);
> @@ -1113,7 +1112,7 @@ static int exfat_move_file(struct inode *inode,
> struct exfat_chain *p_olddir,
> if (!epnew)
> return -EIO;
>
> - memcpy(epnew, epmov, DENTRY_SIZE);
> + *epnew = *epmov;
> if (exfat_get_entry_type(epnew) == TYPE_FILE) {
> epnew->dentry.file.attr |= cpu_to_le16(ATTR_ARCHIVE);
> ei->attr |= ATTR_ARCHIVE;
> @@ -1133,7 +1132,7 @@ static int exfat_move_file(struct inode *inode,
> struct exfat_chain *p_olddir,
> return -EIO;
> }
>
> - memcpy(epnew, epmov, DENTRY_SIZE);
> + *epnew = *epmov;
> exfat_update_bh(new_bh, IS_DIRSYNC(inode));
> brelse(mov_bh);
> brelse(new_bh);
> --
> 2.25.1
next prev parent reply other threads:[~2020-09-16 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200911044525epcas1p4a050411f3049c625b81c7d6516982537@epcas1p4.samsung.com>
2020-09-11 4:45 ` [PATCH 3/3] exfat: replace memcpy with structure assignment Tetsuhiro Kohada
2020-09-16 2:23 ` Sungjong Seo [this message]
2020-09-21 5:51 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015e01d68bd0$5324fe00$f96efa00$@samsung.com' \
--to=sj1557.seo@samsung.com \
--cc=kohada.t2@gmail.com \
--cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mori.takahiro@ab.mitsubishielectric.co.jp \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.