From: Pavel Fedin <p.fedin@samsung.com>
To: "'Andreas Färber'" <afaerber@suse.de>,
"'Peter Crosthwaite'" <peter.crosthwaite@xilinx.com>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] QOM: object_property_add() performance improvement
Date: Fri, 03 Jul 2015 16:38:53 +0300 [thread overview]
Message-ID: <015f01d0b595$9ae33340$d0a999c0$@samsung.com> (raw)
In-Reply-To: <55968D1E.9030308@suse.de>
Hello! Thank you very much for your feedback.
> Nack, I don't like the patch as is. Starting with the unoptimized code
> movement combined with functional changes
Will it be OK if i split it into two parts:
1. Restructuring, introduction of object_property_add_single()
2. Introduction of cache property by itself.
> up to the use of [*] for the
> new property iiuc.
What would you suggest instead? Personally i don't have much preferences, i used it just because it was already there.
What about 'name#' ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
prev parent reply other threads:[~2015-07-03 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 7:50 [Qemu-devel] [PATCH v3] QOM: object_property_add() performance improvement Pavel Fedin
2015-06-27 3:27 ` Peter Crosthwaite
2015-06-29 6:32 ` Pavel Fedin
2015-07-03 13:20 ` Pavel Fedin
2015-07-03 13:24 ` Andreas Färber
2015-07-03 13:38 ` Pavel Fedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015f01d0b595$9ae33340$d0a999c0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=afaerber@suse.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.