RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon

["Sriranjani P" <sriranjani.p@samsung.com>]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 25 November 2022 16:52
> To: Lee Jones <lee@kernel.org>; Rob Herring <robh+dt@kernel.org>;
Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-samsung-
> soc@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Sriranjani P
> <sriranjani.p@samsung.com>; Chanho Park <chanho61.park@samsung.com>;
> Sam Protsenko <semen.protsenko@linaro.org>
> Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
> syscon
> 
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings
> and do not allow other parts of syscon.yaml.  This allows further
customization
> of Samsung SoC bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---

We agree for add separate YAML for  Samsung Exynos and hence I think we can 
go ahead and add  separate yaml for Tesla FSD.
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>

>  .../devicetree/bindings/mfd/syscon.yaml       |  6 ---
>  .../soc/samsung/samsung,exynos-sysreg.yaml    | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 6 deletions(-)  create mode 100644
> Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
>                - rockchip,rk3568-qos
>                - rockchip,rk3588-qos
>                - rockchip,rv1126-qos
> -              - samsung,exynos3-sysreg
> -              - samsung,exynos4-sysreg
> -              - samsung,exynos5-sysreg
> -              - samsung,exynos5433-sysreg
> -              - samsung,exynos850-sysreg
> -              - samsung,exynosautov9-sysreg
> 
>            - const: syscon
> 
> diff --git
> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
> sysre
> +++ g.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> +---
> +$id:
> +https://protect2.fireeye.com/v1/url?k=83e9bb90-e2921107-83e830df-
> 74fe48
> +60001d-5ef78ea8b86e70d7&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung%
> 2Cexynos-
> +sysreg.yaml%23
> +$schema:
> +https://protect2.fireeye.com/v1/url?k=84a37bbf-e5d8d128-84a2f0f0-74fe48
> +60001d-bf5bdaa08b35d382&q=1&e=8db037ae-b28c-44df-a71b-
> 6e7c367bb9d6&u=ht
> +tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - samsung,exynos3-sysreg
> +              - samsung,exynos4-sysreg
> +              - samsung,exynos5-sysreg
> +              - samsung,exynos5433-sysreg
> +              - samsung,exynos850-sysreg
> +              - samsung,exynosautov9-sysreg
> +          - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    system-controller@10010000 {
> +        compatible = "samsung,exynos4-sysreg", "syscon";
> +        reg = <0x10010000 0x400>;
> +    };
> --
> 2.34.1