From: "Kazuki Mizushima" <mizushima.kazuk@jp.fujitsu.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH][XEND]Reprt error for a existing file
Date: Wed, 7 Mar 2007 19:47:54 +0900 [thread overview]
Message-ID: <016f01c760a6$0f67d890$a1ec830a@dirac> (raw)
Hi,
I try to make a patch which reports error for a existing file
to prevent overwriting before the file.
#xm dump-core 12 a.dump
Dumping core of domain: 12 ...
Error: Cannot dump core for existing file /tmp/a.dump
Usage: xm dump-core [-L|--live] [-C|--crash] <Domain> [Filename]
Dump core for a specific domain.
-L, --live Dump core without pausing the domain
-C, --crash Crash domain after dumping core
# xm save 12 a.save
Error: Cannot save for existing file /tmp/a.save
Usage: xm save <Domain> <CheckpointFile>
Save a domain state to restore later.
#
Signed-off-by: Kazuki Mizushima <mizushima.kazuk@jp.fujitsu.com>
diff -r 3ac19fda0bc2 tools/python/xen/xend/XendDomain.py
--- a/tools/python/xen/xend/XendDomain.py Fri Mar 02 12:11:52 2007 +0000
+++ b/tools/python/xen/xend/XendDomain.py Wed Mar 07 14:57:58 2007 +0900
@@ -1094,6 +1094,9 @@ class XendDomain:
if dominfo.getDomid() == DOM0_ID:
raise XendError("Cannot dump core for privileged domain %s" % domid)
+ if os.path.exists(filename):
+ raise XendError("Cannot dump core for existing file %s" % filename)
+
try:
log.info("Domain core dump requested for domain %s (%d) "
"live=%d crash=%d.",
@@ -1190,6 +1193,9 @@ class XendDomain:
if dominfo.getDomid() == DOM0_ID:
raise XendError("Cannot save privileged domain %i" % domid)
+
+ if os.path.exists(dst):
+ raise XendError("Cannot save for existing file %s" % dst)
oflags = os.O_WRONLY | os.O_CREAT | os.O_TRUNC
if hasattr(os, "O_LARGEFILE"):
next reply other threads:[~2007-03-07 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 10:47 Kazuki Mizushima [this message]
2007-03-15 10:18 ` [PATCH][XEND][RESEND]Reprt error for a existing file Kazuki Mizushima
2007-03-15 10:28 ` Keir Fraser
2007-03-15 10:31 ` Petersson, Mats
2007-03-15 12:31 ` Akio Takebe
2007-03-15 12:44 ` Petersson, Mats
2007-03-16 1:37 ` Akio Takebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016f01c760a6$0f67d890$a1ec830a@dirac' \
--to=mizushima.kazuk@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.