RE: [PATCH 3/3] mfd: Add I2C control support for S5M8751

[Sangbeom Kim <sbkim73@samsung.com>]

On Wed, Jun 22, 2011 at 09:51:57PM +0900, Mark Brown wrote:
> If the device doesn't support SPI this could just as well be merged into
> the main driver - the reason for splitting with devices that support
> both is that it gives more flexibility with what gets built into the
> core kernel when both APIs are enabled.

Thank for your comment,
We have a few PMIC (S5M8751, S5M8752 and others).
They have different features. And Each one will have separate core file.
But i2c interface is same.
So, I try to separate i2s code.
I would modify prefix like s5m87xx.

> > +static int s5m8751_i2c_read_device(struct s5m8751 *s5m8751, uint8_t
reg,
> > +					uint8_t *val)
> > +{
> > +	int ret;
> > +	ret = i2c_smbus_read_byte_data(s5m8751->i2c_client, reg);
> > +	if (ret < 0) {
> > +		dev_err(s5m8751->dev, "failed reading at 0x%02x\n", reg);
> > +		return ret;
> > +	}
> > +	*val = (uint8_t)ret;
> 
> Why is this case required?

I want pass the read value by val

Thanks and regards,
SB Kim