AW: [PATCH v2 2/2] mtd: nand: realtek-ecc: Add Realtek external ECC engine support

From: <markus.stockhausen@gmx.de>
To: "'Miquel Raynal'" <miquel.raynal@bootlin.com>
Cc: <richard@nod.at>, <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>
Subject: AW: [PATCH v2 2/2] mtd: nand: realtek-ecc: Add Realtek external ECC engine support
Date: Wed, 10 Sep 2025 17:48:20 +0200	[thread overview]
Message-ID: <017601dc226a$55da4d40$018ee7c0$@gmx.de> (raw)
In-Reply-To: <87ms72elzw.fsf@bootlin.com>

> Von: Miquel Raynal <miquel.raynal@bootlin.com> 
> Gesendet: Mittwoch, 10. September 2025 10:43
>
> > +	ret = FIELD_GET(RTL_ECC_RESULT, status);
> > +	all_one = FIELD_GET(RTL_ECC_ALL_ONE, status);
>
> Maybe you should check whether all_one remains true if there are
> correctable bitflips in your buffer (you may use nandflipbits for that
> purpose). If not, you shall probably spend extra time when checking for
> ret checking if there are less bitflips than the ECC controller can
> correct compared to ones in the *entire* buffer, which would indicate
> that you are really in the presence of an erased page, see:
> https://elixir.bootlin.com/linux/v6.16.5/source/drivers/mtd/nand/raw/nand_base.c#L2841
>
> This helper may be moved if you need it.

ECC engine cannot handle bitflips in erased blocks.
Seems as this helper really can increase robustness
in this case. I will make use of it in the next version.

What do you mean by "can be moved"?

Markus

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/