From: Dmitry Osipenko <digetx@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] i2c: tegra: Make timeout error more informative
Date: Tue, 10 Mar 2020 16:26:41 +0300 [thread overview]
Message-ID: <017aad72-9872-a4aa-dc99-bd7d08c0db14@gmail.com> (raw)
In-Reply-To: <20200310113706.GW1987@ninjato>
10.03.2020 14:37, Wolfram Sang пишет:
> On Mon, Mar 02, 2020 at 08:35:12PM +0300, Dmitry Osipenko wrote:
>> The I2C timeout error message doesn't tell us what exactly failed and some
>> I2C client drivers do not clarify the error either. Adding WARN_ON_ONCE()
>> results in a stacktrace being dumped into KMSG, which is very useful for
>> debugging purposes.
>
> This is good for debugging, in deed, yet not good in the generic case.
> Timeouts are not an exception on the I2C bus (think of an EEPROM which
> is busy during an erase cycle), so it shouldn't be printed at all.
>
> This prinout should rather be dropped or at least be dev_dbg.
Oh, well. I'll keep this debugging applied locally then, it's quite
unfortunate when something fails silently :)
next prev parent reply other threads:[~2020-03-10 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:35 [PATCH v1] i2c: tegra: Make timeout error more informative Dmitry Osipenko
2020-03-02 17:35 ` Dmitry Osipenko
[not found] ` <20200302173512.2743-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-10 11:37 ` Wolfram Sang
2020-03-10 11:37 ` Wolfram Sang
2020-03-10 13:26 ` Dmitry Osipenko [this message]
[not found] ` <017aad72-9872-a4aa-dc99-bd7d08c0db14-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-10 18:15 ` Wolfram Sang
2020-03-10 18:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017aad72-9872-a4aa-dc99-bd7d08c0db14@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.